Replace dependence plot with highchart lib #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 4, 2022 13:10
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 91 91
Lines 4379 4379
=======================================
Hits 2938 2938
Misses 1441 1441
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
imatiach-msft
approved these changes
Feb 9, 2022
libs/core-ui/src/index.ts
Outdated
| @@ -29,6 +29,8 @@ export * from "./lib/util/generateRoute"; | |||
| export * from "./lib/util/getRandomId"; | |||
| export * from "./lib/util/getCohortFilterCount"; | |||
| export * from "./lib/util/getTreatmentBarChartOptions"; | |||
| export * from "./lib/util/getDependencyChartOptions"; | |||
| export * from "./lib/util/getDependencyChartOptions"; | |||
There was a problem hiding this comment.
getDependencyChartOptions imported twice here?
| } | ||
| }, | ||
| yAxis: { | ||
| labels: { |
There was a problem hiding this comment.
maybe refactor out the common xAxis and yAxis properties to a method?
| } : ${this.props.selectedWeightLabel}`; | ||
| return ( | ||
| <div className={classNames.DependencePlot}> | ||
| <div className={classNames.chartWithAxes}> |
There was a problem hiding this comment.
what do you think about replacing the div with stack from FluentUI?
1 similar comment
added 2 commits
February 9, 2022 14:40
…dgets into zhb/FeatureImportance
added 3 commits
February 9, 2022 18:06
…olbox into zhb/FeatureImportance
added 3 commits
February 10, 2022 09:39
…olbox into zhb/FeatureImportance
1 similar comment
gaugup
pushed a commit
that referenced
this pull request
Feb 27, 2022
* temp * test * temp * refactor * tooltip * cache * tooltip template * remove dup * e2e * test * test * e2e * test * remove animation * test * fix
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace dependence plot from feature importance dashboard with highchart lib
Areas changed
npm packages changed:
Python packages changed:
Tests
Screenshots (if appropriate):
Documentation: