Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release error on unknown shell command when uploading to pypi #1224

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Fix release error on unknown shell command when uploading to pypi.
It seems the "pypa/gh-action-pypi-publish@master" isn't able to take "shell: bash -l {0}" to use miniconda.
I'm hoping this will fix it, but I'm not quite sure, as then we won't be activating the correct env.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1224 (ec31c8d) into main (fd5d3a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1224   +/-   ##
=======================================
  Coverage   67.19%   67.19%           
=======================================
  Files          91       91           
  Lines        4393     4393           
=======================================
  Hits         2952     2952           
  Misses       1441     1441           
Flag Coverage Δ
unittests 67.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5d3a4...ec31c8d. Read the comment docs.

@imatiach-msft imatiach-msft merged commit 01b5e4b into main Feb 14, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-github-action-step branch February 14, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants