Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user defined cohort injection logic into raiwidgets #1237

Merged
merged 7 commits into from
Feb 24, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Feb 19, 2022

Description

This change proposes the injection of user defined cohorts defined in SDK into the ResponsibleAIDashboard. The user defined cohorts are added into the dashboard_input as cohortData (which in python world is a list of Cohort class objects.). The injection logic is tested in the test_responsibleai_dashboard.py.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #1237 (f67e1b9) into main (ede5f43) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   66.01%   65.61%   -0.40%     
==========================================
  Files          91       91              
  Lines        4475     4502      +27     
==========================================
  Hits         2954     2954              
- Misses       1521     1548      +27     
Flag Coverage Δ
unittests 65.61% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/responsibleai_dashboard.py 0.00% <0.00%> (ø)
...idgets/raiwidgets/responsibleai_dashboard_input.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede5f43...f67e1b9. Read the comment docs.

gaugup and others added 3 commits February 23, 2022 00:00
* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <[email protected]>

* Remove unused imports

Signed-off-by: Gaurav Gupta <[email protected]>
Signed-off-by: Gaurav Gupta <[email protected]>
1 similar comment
@gaugup gaugup enabled auto-merge (squash) February 23, 2022 18:57
@gaugup gaugup merged commit e2b9444 into main Feb 24, 2022
@gaugup gaugup deleted the gaugup/AddPreBuiltInjectionIntoRAIWidgets branch February 24, 2022 10:07
gaugup added a commit that referenced this pull request Feb 27, 2022
* Add pre-built cohort injection logic into raiwidgets

Signed-off-by: Gaurav Gupta <[email protected]>

* add conftest.py

Signed-off-by: Gaurav Gupta <[email protected]>

* Create pytest fixtures raiwidgets tests (#1232)

* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <[email protected]>

* Remove unused imports

Signed-off-by: Gaurav Gupta <[email protected]>

* Fix sorted imports

Signed-off-by: Gaurav Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants