Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toggle for switching classes in binary classification case #1444

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented May 23, 2022

Description

In the binary classification case for the aggregate feature importances and local importances (in the explanation component which is used in the RAI Dashboard, explanation dashboard, and error analysis dashboard), this PR adds the same drop-down as in multiclass case to allow the user to switch between the two binary classes. Please see long-standing item:

#374

Previously we would only show class 0 to users which was really, really confusing them a lot.

Screenshot for aggregate feature importances view:

image

Checklist

  • I have added screenshots above for all UI changes.
  • Documentation was updated if it was needed.
  • New tests were added or changes were manually verified.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #1444 (70f32cb) into main (3ed990b) will increase coverage by 1.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
+ Coverage   85.39%   87.15%   +1.76%     
==========================================
  Files          58      104      +46     
  Lines        2862     4897    +2035     
==========================================
+ Hits         2444     4268    +1824     
- Misses        418      629     +211     
Flag Coverage Δ
unittests 87.15% <ø> (+1.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponsibleai/responsibleai/_managers/base_manager.py 100.00% <0.00%> (ø)
...nsibleai/responsibleai/_managers/causal_manager.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_config.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_interfaces.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_internal/constants.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/shared/versions.py 100.00% <0.00%> (ø)
...ibleai/_tools/causal/dashboard_schemas/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_input_processing.py 93.44% <0.00%> (ø)
responsibleai/responsibleai/managers/__init__.py 100.00% <0.00%> (ø)
...sponsibleai/responsibleai/rai_insights/__init__.py 100.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed990b...70f32cb. Read the comment docs.

1 similar comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants