Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataset explorer plot with count not displaying #1454

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented May 31, 2022

Description

Fixed issue #1453 where count plot is not displaying.

The main problem was that count uses "none" as the metadata name, which does not have any sorted categorical values (see

which sets treatAsCategorical=True, but does not specify categorical values). However, when creating the highchart options, we skip the step to pass the values of the "none" group, since we iterate over all categorical values. There are several possible fixes here (another I had was to insert an array with some dummy "count" value for the categoricals values in JointDataset which also worked), but I felt this was the least intrusive and safest one.

Screenshot of fixed plot:
image

Checklist

  • I have added screenshots above for all UI changes.
  • Documentation was updated if it was needed.
  • New tests were added or changes were manually verified.

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #1454 (2e56401) into main (65ef440) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          80       80           
  Lines        3556     3556           
=======================================
  Hits         3177     3177           
  Misses        379      379           
Flag Coverage Δ
unittests 89.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ef440...2e56401. Read the comment docs.

2 similar comments
@romanlutz
Copy link
Contributor

In the screenshot I don't see none showing up. What am I missing? [Note: I don't mean to hold this up at all. Feel free to proceed in any case.]

@tongyu-microsoft
Copy link
Contributor

In the screenshot I don't see none showing up. What am I missing? [Note: I don't mean to hold this up at all. Feel free to proceed in any case.]

@romanlutz, I checked that locally, the none shows up in the pop up when you hover over each column in the chart. For other y-axis choices like categorical features, we are displaying apple: 5, banana: 8. And for Ilya's change for count, we display none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants