Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding extra statement in PR template for e2e #1461

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Adding extra statement in PR template for e2e #1461

merged 3 commits into from
Jun 2, 2022

Conversation

vinuthakaranth
Copy link
Contributor

Description

Adding extra statement in PR template to ensure e2e tests are added if PR has UI changes.

Checklist

  • I have added screenshots above for all UI changes.
  • Documentation was updated if it was needed.
  • New tests were added or changes were manually verified.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/adde2eteststat/dashboard/index.html

@vinuthakaranth
update
d2865ec 
Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #1461 (d2865ec) into main (7fd9b53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         100      100           
  Lines        4801     4801           
=======================================
  Hits         4177     4177           
  Misses        624      624
Flag Coverage Δ
unittests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd9b53...d2865ec. Read the comment docs.

romanlutz
romanlutz approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW feel free to merge this into main since it has no effect on code that we may need to ship urgently.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/adde2eteststat/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit cf0c144 into main Jun 2, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/adde2eteststat branch June 2, 2022 22:08
ms-kashyap pushed a commit that referenced this pull request Jun 7, 2022
@vinuthakaranth @ms-kashyap
Adding extra statement in PR template for e2e (#1461)
2101dd1 
* update

Signed-off-by: vinutha karanth <[email protected]>

* update

Signed-off-by: vinutha karanth <[email protected]>
This was referenced Jun 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@gaugup gaugup gaugup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinuthakaranth @codecov-commenter @romanlutz @gaugup