[office-ui upgrade] Move checkbox to fluentui #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: Ke Xu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
+ Coverage 85.39% 89.48% +4.09%
==========================================
Files 58 84 +26
Lines 2862 3652 +790
==========================================
+ Hits 2444 3268 +824
+ Misses 418 384 -34
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: vinutha karanth <[email protected]>
…olbox into vikarant/officeUIUpgrade1
Signed-off-by: vinutha karanth <[email protected]>
vinuthakaranth
requested review from
romanlutz,
xuke444,
riedgar-ms,
imatiach-msft and
tongyu-microsoft
as code owners
vinuthakaranth
changed the title
gaugup
reviewed
Jun 6, 2022
gaugup
approved these changes
Jun 6, 2022
tongyu-microsoft
approved these changes
Jun 7, 2022
imatiach-msft
approved these changes
Jun 7, 2022
romanlutz
approved these changes
Jun 7, 2022
|
I am very excited about this! Are we planning to replace other elements with fluentui elements soon, too? |
Yes, all elements will be updated in coming PRs one by one. |
riedgar-ms
approved these changes
Jun 7, 2022
ms-kashyap
pushed a commit
that referenced
this pull request
Jun 7, 2022
* update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> * update tslint Signed-off-by: Ke Xu <[email protected]> * checkbox update Signed-off-by: vinutha karanth <[email protected]> * lintfix Signed-off-by: vinutha karanth <[email protected]> Co-authored-by: Ke Xu <[email protected]>
This was referenced Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving checkbox to fluent UI. No UI changes, Just migration.
Checklist