Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model overview - Dataset cohorts]: At 320*256 viewport content is getting truncated and graph is not visible. #1801

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Nov 4, 2022

Fix Model overview - Dataset cohorts]: At 320*256 viewport content is getting truncated and graph is not visible.

Description

graphTrunc2

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1801 (f6449fc) into main (51679b3) will decrease coverage by 4.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1801      +/-   ##
==========================================
- Coverage   87.53%   82.80%   -4.74%     
==========================================
  Files          96       55      -41     
  Lines        5390     2907    -2483     
==========================================
- Hits         4718     2407    -2311     
+ Misses        672      500     -172     
Flag Coverage Δ
unittests 82.80% <ø> (-4.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
responsibleai/responsibleai/_interfaces.py
responsibleai/responsibleai/feature_metadata.py
...leai/responsibleai/modelanalysis/model_analysis.py
...ai/databalanceanalysis/feature_balance_measures.py
...nsibleai/databalanceanalysis/data_balance_utils.py
responsibleai/responsibleai/_config/__init__.py
...sibleai/responsibleai/_tools/shared/base_result.py
...ai/responsibleai/_tools/error_analysis/__init__.py
...ibleai/responsibleai/managers/explainer_manager.py
...i/responsibleai/managers/counterfactual_manager.py
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinuthakaranth vinuthakaranth merged commit c541255 into main Nov 4, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/graphTrunc branch November 4, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants