Add forecasting dashboard - UI - time series selection & forecast comparison #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but not transformations
romanlutz
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
+ Coverage 92.44% 93.35% +0.90%
==========================================
Files 103 93 -10
Lines 4832 4574 -258
==========================================
- Hits 4467 4270 -197
+ Misses 365 304 -61
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
libs/forecasting/src/lib/ForecastingDashboard/Controls/ForecastComparison.tsx
Show resolved
Hide resolved
libs/forecasting/src/lib/ForecastingDashboard/Controls/ForecastComparison.tsx
Outdated
Show resolved
Hide resolved
libs/forecasting/src/lib/ForecastingDashboard/Controls/ForecastComparison.tsx
Outdated
Show resolved
Hide resolved
libs/forecasting/src/lib/ForecastingDashboard/ForecastingDashboard.styles.ts
Outdated
Show resolved
Hide resolved
libs/forecasting/src/lib/ForecastingDashboard/ForecastingDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/forecasting/src/lib/ForecastingDashboard/ForecastingDashboard.tsx
Outdated
Show resolved
Hide resolved
libs/model-assessment/src/lib/ModelAssessmentDashboard/AvailableTabs.ts
Outdated
Show resolved
Hide resolved
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/CohortList.tsx
Show resolved
Hide resolved
…olbox into romanlutz/forecasting_ui_basic
xuke444
reviewed
Jan 10, 2023
xuke444
reviewed
Jan 10, 2023
xuke444
reviewed
Jan 10, 2023
xuke444
reviewed
Jan 10, 2023
xuke444
reviewed
Jan 10, 2023
libs/forecasting/src/lib/ForecastingDashboard/Controls/ForecastComparison.tsx
Outdated
Show resolved
Hide resolved
xuke444
reviewed
Jan 10, 2023
libs/forecasting/src/lib/ForecastingDashboard/Controls/ForecastComparison.tsx
Outdated
Show resolved
Hide resolved
xuke444
reviewed
Jan 10, 2023
libs/model-assessment/src/lib/ModelAssessmentDashboard/Cohort/ShiftCohort.tsx
Show resolved
Hide resolved
xuke444
reviewed
Jan 10, 2023
libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/TabsView/TabsView.tsx
Show resolved
Hide resolved
…olbox into romanlutz/forecasting_ui_basic
vinuthakaranth
approved these changes
Jan 11, 2023
libs/forecasting/src/lib/ForecastingDashboard/Controls/getForecastPrediction.ts
Show resolved
Hide resolved
imatiach-msft
approved these changes
Jan 11, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a copy of #1874 but trimmed down to allow for easier code reviews. The removed portion is about what-if transformations, so this PR only enables the selection of a time series (internally "cohort") and then automatically generates a forecast comparison plot:
Once this is merged and #1874 is updated, #1874 will provide the diff, i.e., it will add transformations, a UI to create them, a table to present them, and code to generate the corresponding forecasts to add them to the forecast comparison plot.
Tests will be added end of January/early February to accelerate the POC and get feedback from customers for validation purposes first.
Checklist