Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional support for IS_CROWD for OD COCO label format #2395

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Oct 25, 2023

Description

Fix for the below stack trace with OD labels without IS_CROWD key:

<class 'KeyError'>
File "./rai_vision_insights.py", line 456 in main
rai_vi = RAIVisionInsights(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/rai_vision_insights/rai_vision_insights.py", line 239 in init
test = transform_object_detection_labels(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/utils/image_utils.py", line 134 in transform_object_detection_labels
int(label[IS_CROWD])])

Making it optional instead of removing it, due to significance (and potential support in future) for use-cases with crowds of people: AlexeyAB/darknet#5567 (comment)

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #2395 (78ed31f) into main (e4487bf) will decrease coverage by 10.15%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main    #2395       +/-   ##
===========================================
- Coverage   89.09%   78.94%   -10.15%     
===========================================
  Files         122       26       -96     
  Lines        6732     2280     -4452     
===========================================
- Hits         5998     1800     -4198     
+ Misses        734      480      -254     
Flag Coverage Δ
unittests 78.94% <50.00%> (-10.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i_vision/responsibleai_vision/utils/image_utils.py 86.95% <50.00%> (-1.11%) ⬇️

... and 121 files with indirect coverage changes

1 similar comment
@Advitya17 Advitya17 marked this pull request as ready for review October 26, 2023 02:50
@Advitya17 Advitya17 merged commit 1408ef5 into main Nov 1, 2023
101 of 104 checks passed
@Advitya17 Advitya17 deleted the agemawat/iscrowd_fix branch November 1, 2023 15:26
@Mohamed97643021
Copy link

Mohamed97643021 commented Nov 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants