Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build errors due to changed exception messages and UCI repository expired certificate #2413

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Nov 13, 2023

Description

fix build errors due to:
1.) changed exception messages from huggingface HFValidationError and
2.) UCI repository expired certificate

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-builds-errs branch 2 times, most recently from a847c5e to dd75a6b Compare November 13, 2023 19:43
@imatiach-msft imatiach-msft changed the title fix build error due to changed exception messages fix build error due to changed exception messages and UCI repository expired certificate Nov 13, 2023
@imatiach-msft imatiach-msft changed the title fix build error due to changed exception messages and UCI repository expired certificate fix build errors due to changed exception messages and UCI repository expired certificate Nov 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73dc621) 92.40% compared to head (c9dcec3) 88.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   92.40%   88.46%   -3.95%     
==========================================
  Files         108      134      +26     
  Lines        5415     7695    +2280     
==========================================
+ Hits         5004     6807    +1803     
- Misses        411      888     +477     
Flag Coverage Δ
unittests 88.46% <ø> (-3.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-builds-errs branch 2 times, most recently from c8ac2ce to cc65850 Compare November 13, 2023 20:34
1 similar comment
@imatiach-msft imatiach-msft merged commit d033292 into main Nov 14, 2023
152 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-builds-errs branch November 14, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants