Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fix for 'Error Analysis' header #2415

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Nov 14, 2023

Actual Result: 'Error Analysis' text is not defined as heading programmatically.

Observation: The role is defined as "static text" for the 'Error Analysis'.

image

Solution: 'Error Analysis' text which is visually appearing as heading should be defined as headings present under 'analyse_ model' page. It should be defined as heading

/

.

image

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@Advitya17 Advitya17 changed the title Accessibility fix for 'Error Analysis' Accessibility fix for 'Error Analysis' header Nov 14, 2023
@Advitya17 Advitya17 merged commit 4c01e0c into main Nov 14, 2023
66 checks passed
@Advitya17 Advitya17 deleted the agemawat/header_access branch November 14, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants