Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-labels for sliders and checkboxes/DetailsList #2419

Merged
merged 13 commits into from
Nov 21, 2023
1 change: 1 addition & 0 deletions libs/core-ui/src/lib/Cohort/CohortList/CohortList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export class CohortList extends React.Component<
selectionPreservedOnEmptyClick
checkboxVisibility={CheckboxVisibility.hidden}
onRenderItemColumn={this.renderItemColumn}
ariaLabel="Cohort List"
Advitya17 marked this conversation as resolved.
Show resolved Hide resolved
/>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export class CohortBar extends React.Component<
items={this.props.cohorts}
selectionMode={SelectionMode.none}
columns={columns}
ariaLabel="Cohort list"
/>
</Panel>
))}
Expand Down
1 change: 1 addition & 0 deletions libs/counterfactuals/src/lib/CounterfactualList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export class CounterfactualList extends React.Component<
onRenderItemColumn={this.renderItemColumn}
onRenderRow={this.renderRow}
onRenderDetailsFooter={this.onRenderDetailsFooter}
ariaLabel="Counterfactual list"
/>
);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ export class AggregateBalanceMeasuresTable extends React.PureComponent<IAggregat
selectionMode={SelectionMode.none}
layoutMode={DetailsListLayoutMode.justified}
checkboxVisibility={CheckboxVisibility.hidden}
ariaLabelForSelectAllCheckbox="Select all rows"
ariaLabel="Aggregate balance measures list"
/>
</Stack.Item>
</Stack>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export class TableList extends React.Component<
selection={this._selection}
setKey="set"
onItemInvoked={this.props.selectItem}
ariaLabel="Table view list"
/>
</MarqueeSelection>
</Stack.Item>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export class VisionExplanationDashboardCommon extends React.Component<
min={20}
id="dataExplorerThumbnailSize"
className={this.props.classNames.slider}
ariaLabel="Slider for image thumbnail size"
label={localization.InterpretVision.Dashboard.thumbnailSize}
defaultValue={50}
showValue={false}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export class CohortList extends React.Component<
selectionMode={SelectionMode.none}
checkboxVisibility={CheckboxVisibility.hidden}
onRenderItemColumn={this.renderItemColumn}
ariaLabel="Cohort list"
/>
{this.state.currentEditCohort && (
<CohortEditor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ export class FeatureConfigurationFlyout extends React.Component<
selectionMode={SelectionMode.multiple}
selection={this._selection}
checkboxVisibility={CheckboxVisibility.always}
ariaLabelForSelectAllCheckbox="Select all rows"
ariaLabel="Feature selection table"
/>
</Stack>
</Panel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ export class MetricConfigurationFlyout extends React.Component<
selectionMode={SelectionMode.multiple}
selection={this._selection}
checkboxVisibility={CheckboxVisibility.always}
ariaLabelForSelectAllCheckbox="Select all rows"
ariaLabel="Metric selection table"
/>
</Stack>
</Panel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export class ObjectDetectionWidgets extends React.PureComponent<IObjectDetection
/>
<Slider
id="modelOverviewIoUThreshold"
ariaLabel="Slider for IoU threshold"
label={
localization.ModelAssessment.ModelOverview.iouThresholdDropdown.name
}
Expand Down
Loading