-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacing "react-native bundle" calls by "react-native rnx-bundle" results in huge console logs #2419
Comments
Same issue for me |
Do you use Hermes? Do these "huge console logs" come from the Hermes compiler? If so, try this workaround to disable warnings: #2416 (comment) We can't control the console output of Hermes. If you think this is a real issue, you should file it on their GitHub instead. |
I do use Hermes! |
For the blocking bundle issue, do you have a repro? I've not seen this myself so having a repro would help us investigate. |
At this time, I did not publish a repro project. The repro steps are pretty simple:
I'll try to set one up as soon as I have some free time (and a Macbook available!) |
For fix and workaround, see #2416 (comment). |
Summary: Limit diagnostics width output by `hermesc` as they may cause slowdowns or even crashes in Gradle/Xcode when a minified bundle is used as input. This occurs because Hermes is unable to determine the terminal width when executed by Gradle/Xcode, and falls back to "unlimited". If the input is a minified bundle, Hermes will output the whole bundle for each warning. See issues filed: - microsoft/rnx-kit#2416 - microsoft/rnx-kit#2419 - microsoft/rnx-kit#2424 ## Changelog: [GENERAL] [FIXED] - Limit diagnostics width output by `hermesc` Pull Request resolved: #37531 Test Plan: See listed issues for repros. Reviewed By: cipolleschi Differential Revision: D46102686 Pulled By: cortinico fbshipit-source-id: 1b821cad7ef0d561a5e1c13a7aedf9b10164620a
Summary: Limit diagnostics width output by `hermesc` as they may cause slowdowns or even crashes in Gradle/Xcode when a minified bundle is used as input. This occurs because Hermes is unable to determine the terminal width when executed by Gradle/Xcode, and falls back to "unlimited". If the input is a minified bundle, Hermes will output the whole bundle for each warning. See issues filed: - microsoft/rnx-kit#2416 - microsoft/rnx-kit#2419 - microsoft/rnx-kit#2424 ## Changelog: [GENERAL] [FIXED] - Limit diagnostics width output by `hermesc` Pull Request resolved: #37531 Test Plan: See listed issues for repros. Reviewed By: cipolleschi Differential Revision: D46102686 Pulled By: cortinico fbshipit-source-id: 1b821cad7ef0d561a5e1c13a7aedf9b10164620a
What happened?
Hello,
I have set up rnx-kit to bundle my application.
I replaced the
react-native start
scripts withreact-native rnx-start
, and it works perfectly.I also wanted to replace the calls to
react-native bundle
withreact-native rnx-bundle
. (For Android, I usedbundleCommand = "rnx-bundle"
in build.gradle, and for iOS I usedexport BUNDLE_COMMAND=rnx-bundle
in the bundle phase on XCode.For Android, this works, but there is a problem: the whole generated js bundle is logged in the console, and I suspect it is logged several times in a row because my log file was over 300 megabytes at the end of the build.
For iOS, when trying to archive, it also logs a lot of lines related to the source code, but the bundle step never finishes (as if the bundle script was still in "waiting for input" mode).
So several questions:
rnx-bundle
as a drop-in replacement forreact-native bundle
?If we can't replace
react-native bundle
directly byreact-native rnx-bundle
, how should we use it?Affected Package
@rnx-kit/cli
Version
0.16.9
Which platforms are you seeing this issue on?
System Information
Steps to Reproduce
Code of Conduct
The text was updated successfully, but these errors were encountered: