Adding tslib to dependencies #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
requested review from
eddynaka,
GabeDeBacker,
jeffersonking,
michaelcfanning and
rwjblue
as code owners
rwjblue
approved these changes
May 4, 2021
There was a problem hiding this comment.
These helpers are being emitted due to importHelpers: true in tsconfig.json:
sarif-js-sdk/tsconfig-base.json
Line 7 in af6eeec
Was chatting with @scalvert about this out of band, and I think the two options are:
- add the
tslibdep (which is what this PR does) - change
importHelperstofalse(the default)
I don't feel super strongly either way, so this seems fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiled output depends on
tslib, and when not present this generates an error (expectedly!). This fix addstslibtojest-sarif's dependencies.