Setup basic GitHub Actions CI #4
Conversation
rwjblue
requested review from
eddynaka,
GabeDeBacker,
jeffersonking,
michaelcfanning and
scalvert
as code owners
|
|
rwjblue
force-pushed
the
rwjblue/ci-setup
branch
from
d116d53
to
376e720
Compare
| strategy: | ||
| matrix: | ||
| os: [windows, ubuntu] | ||
|
|
There was a problem hiding this comment.
nit: remove double empty lines
|
Currently failing due to #5 (moving to draft while we fix that). |
rwjblue
force-pushed
the
rwjblue/ci-setup
branch
2 times, most recently
from
0346525
to
826b247
Compare
|
What is the consideration between using I presume we have more |
Yes, you are totally correct - I would absolutely expect us to have more macOS users than Ubuntu users. Unfortunately, the macOS CI jobs are a bit finicky (slow to start, less overall capacity, transient failures, etc) in other repos whereas the Ubuntu ones seem to be pretty rock solid. Additionally (I think I mentioned this inline in another comment), we don't really know if we will have platform specific code ATM. Even if we eventually do have a number of platform specific things, it is very likely to be the same between macOS and Ubuntu (essentially Windows is the one where most platform specific difference are super obvious). |
Thanks! That's valuable insight. I've been using |
|
@jeffersonking agree with what @rwjblue is saying, and that's been my experience too. The macos jobs would quite frequently fail for random reasons, which of course can be quite annoying in terms of test stability. Having to repeatedly re-run the jobs not only ended up being inconvenient, but it also degraded the confidence level of the stability of the test suites. |
|
@rwjblue needs a rebase with main. |
|
Probably good to mark this ready for review too, after the rebase. |
rwjblue
force-pushed
the
rwjblue/ci-setup
branch
from
826b247
to
71587ad
Compare
Without this, `prettier` has issue with `\r\n` on windows (it expects only `\n`).
No description provided.