Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest changes from Sarif-sdk #40

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

yongyan-gh
Copy link
Collaborator

@yongyan-gh yongyan-gh commented Mar 29, 2022

Including below changes and unit tests:

@scalvert
Copy link
Collaborator

Thanks for merging this. I've just commented on microsoft/sarif-sdk#2458 and microsoft/sarif-sdk#2435.

Since we've moved the source to this repo, I was remiss in removing the source from the sarif-sdk repo in favor of this, and republishing.

We should determine a plan to:

  • decommission the source from the sarif-sdk repo (delete it)
  • publish a new version from this repo (it can likely just be a patch, since it'll only be changing the repository path

This should not break/interrupt consumers, since the packages will be functionally the same.

@scalvert
Copy link
Collaborator

These changes seem fine, since they're just a merge from the original source. Thanks!

@eddynaka
Copy link
Contributor

Thanks for merging this. I've just commented on microsoft/sarif-sdk#2458 and microsoft/sarif-sdk#2435.

Since we've moved the source to this repo, I was remiss in removing the source from the sarif-sdk repo in favor of this, and republishing.

We should determine a plan to:

  • decommission the source from the sarif-sdk repo (delete it)
  • publish a new version from this repo (it can likely just be a patch, since it'll only be changing the repository path

This should not break/interrupt consumers, since the packages will be functionally the same.

Sounds perfect.
I asked @yongyan-gh to migrate one more file (the local action) to validate the formatter.
Once we have that, we could review/merge/publish/delete from sarif-sdk

@yongyan-gh , also update the README.file, creating the badge

@eddynaka eddynaka merged commit e78e352 into main Mar 30, 2022
@eddynaka eddynaka deleted the users/yongyan-gh/eslint-sarif-formatter branch March 30, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants