Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't throw a warning if an output folder is specified #542

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

DaveTryon
Copy link
Contributor

As called out in #500, the code returns a warning if the manifest output folder is explicitly specified by the -m parameter. Logging a warning for normal and supported operation is bad form. It was causing grief for a team that wanted to control the output location but had a zero-warning policy on their pipeline.

Side note: The default verbosity level for logging (defined at https://github.com/microsoft/sbom-tool/blob/main/src/Microsoft.Sbom.Common/Constants.cs#L16) is Warning, so this message will only be displayed if a non-default verbosity is specified. Presumably a higher verbosity would be the first diagnostic step if a problem were to occur, so this feels unlikely to cause any real-world problems.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (09994cd) to head (9edf5f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         248      248           
  Lines        7572     7572           
  Branches      900      900           
=======================================
  Hits         4523     4523           
  Misses       2637     2637           
  Partials      412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pownkel pownkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveTryon DaveTryon merged commit 3d1a59f into microsoft:main Apr 10, 2024
6 checks passed
@DaveTryon DaveTryon deleted the reclassify-manifest-message branch April 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants