fix: Don't throw a warning if an output folder is specified #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As called out in #500, the code returns a warning if the manifest output folder is explicitly specified by the
-m
parameter. Logging a warning for normal and supported operation is bad form. It was causing grief for a team that wanted to control the output location but had a zero-warning policy on their pipeline.Side note: The default verbosity level for logging (defined at https://github.com/microsoft/sbom-tool/blob/main/src/Microsoft.Sbom.Common/Constants.cs#L16) is
Warning
, so this message will only be displayed if a non-default verbosity is specified. Presumably a higher verbosity would be the first diagnostic step if a problem were to occur, so this feels unlikely to cause any real-world problems.