-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redaction workflow logic #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
May 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 59.36% 59.82% +0.46%
==========================================
Files 266 268 +2
Lines 8101 8249 +148
Branches 947 972 +25
==========================================
+ Hits 4809 4935 +126
- Misses 2870 2886 +16
- Partials 422 428 +6 ☔ View full report in Codecov by Sentry. |
DaveTryon
reviewed
May 21, 2024
DaveTryon
reviewed
May 21, 2024
DaveTryon
reviewed
May 21, 2024
DaveTryon
reviewed
May 21, 2024
src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Entities/CreationInfo.cs
Outdated
Show resolved
Hide resolved
DaveTryon
reviewed
May 21, 2024
@DaveTryon @alisonlomaka thanks for the feedback, I believe I have made all the requested changes, let me know if I missed anything! |
DaveTryon
reviewed
May 22, 2024
DaveTryon
reviewed
May 22, 2024
DaveTryon
reviewed
May 22, 2024
DaveTryon
approved these changes
May 22, 2024
tarun06
pushed a commit
to tarun06/sbom-tool
that referenced
this pull request
Jul 21, 2024
* Add redaction workflow logic * Fix test * PR feedback pt 1 * PR feedback pt 2 * PR feedback pt 3 * PR feedback pt 4 * PR feedback pt 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #575, which added the CLI plumbing for the
redact
verb. This PR populates the redact workflow with the redaction logic. The current redaction logic involves the following components:packages.hasFiles
entriespackages.sourceInfo
entries (note that this property is not populated for SBOMs generated by this tool, but we have seen syft SBOMs in which this property contains file information)