Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for osx-arm64 #756

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Add support for osx-arm64 #756

merged 4 commits into from
Oct 16, 2024

Conversation

DaveTryon
Copy link
Contributor

This adds the ability to produce an osx-arm64 version of the tool. It also includes a small doc change about building locally--local builds of arm-64 should not be treated as official since we will be publishing this as a separate package.

@DaveTryon DaveTryon requested a review from a team as a code owner October 16, 2024 19:42
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (a6b9f9c) to head (1dca241).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files         277      277           
  Lines        8651     8651           
  Branches     1006     1006           
=======================================
  Hits         6067     6067           
  Misses       2065     2065           
  Partials      519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jalkire jalkire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any kind of signing that should occur for Mac?

@DaveTryon DaveTryon merged commit 552c36c into main Oct 16, 2024
6 checks passed
@DaveTryon DaveTryon deleted the DaveTryon/add-osx-arm64 branch October 16, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants