Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for MSVS 2022 #59

Closed
vadz opened this issue Aug 24, 2021 · 4 comments
Closed

Support for MSVS 2022 #59

vadz opened this issue Aug 24, 2021 · 4 comments
Assignees
@timheuer
Labels
❓ needs-more-info Need more information to accurately resolve

Comments

@vadz
Copy link

vadz commented Aug 24, 2021

Trying to use this action with the just added "windows-2022" environment (see actions/runner-images#3949) doesn't work, msbuild is not found. It would be nice if it could be updated to support the latest version. TIA!
@timheuer timheuer self-assigned this Aug 24, 2021
@timheuer timheuer added the ❓ needs-more-info Need more information to accurately resolve label Aug 24, 2021
@timheuer
Copy link
Member

timheuer commented Aug 24, 2021 •
edited
Loading

Do you have a repo you can share with the settings you are using? Or just the default? I think this may be due to needing -prerelease available...which is #45 which I need to merge...does that sound right @heaths that it wouldn't be found even if only one on machine because it is preview?

@heaths
Copy link
Member

heaths commented Aug 24, 2021

Yes, as long as the user didn't specify their own conflicting vs-version input.

@vadz vadz mentioned this issue Aug 24, 2021
Merged
@vadz
Copy link
Author

vadz commented Aug 24, 2021

I think this may be due to needing -prerelease available...which is #45 which I need to merge...

Just noticed that you've merged it and using it does allow the action to find MSBuild in this environment, thanks! There are other problems in my builds, but they're unrelated to this action, so I think this issue can be closed now.

Thanks again!

@timheuer
Copy link
Member

Awesome, thank you for confirming

menees added a commit to menees/MegaBuild that referenced this issue Nov 29, 2021
@menees
Update build.yml
843b730 
microsoft/setup-msbuild#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timheuer timheuer

Labels
❓ needs-more-info Need more information to accurately resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timheuer @vadz @heaths