-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for selective erase operations (#14046)
This PR adds support for the selective erase escape sequences: `DECSED`, `DECSEL`, and `DECSCA`. They provide a way of marking certain areas of the screen as "protected", so you can erase the content everywhere else without affecting those protected areas. This adds another bit in the `CharacterAttributes` enum to track the protected status of each cell, and an operation triggered by the `DECSCA` sequence which can toggle that bit in the active attributes. There there are two new erase operations triggered by the `DECSED` and `DECSEL` sequences, which work similar to the existing `ED` (erase in display) and `EL` (erase in line) operations, but which only apply to unprotected cells. I've also updated the `DECRQSS` settings request, so you can query the active protected attribute status. ## Validation Steps Performed I've manually confirmed that we pass the selective erase tests in Vttest now, and I've also manually tested some more complicated edge cases and confirmed that we match the behavior of the hardware VT240 emulator in MAME. For unit testing I've extended the existing erase tests to cover selective erase as an additional option, I've added a test covering the `DECSCA` sequence, and I've extended the `DECRQSS` adapter test to confirm the attribute reporting is working. Closes #14029
- Loading branch information
Showing
15 changed files
with
350 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.