Skip to content

Commit

Permalink
I broke the spellcheck when I force-merged #2193
Browse files Browse the repository at this point in the history
  • Loading branch information
zadjii-msft committed Apr 13, 2020
1 parent ffbdfe3 commit 76e1184
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
2 changes: 2 additions & 0 deletions .github/actions/spell-check/whitelist/whitelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,7 @@ ggggggg
gh
github
githubusercontent
gitlab
gle
globals
gmail
Expand Down Expand Up @@ -986,6 +987,7 @@ GWL
GWLP
gwsz
HABCDEF
hackathon
halfwidth
HALTCOND
HANGEUL
Expand Down
20 changes: 10 additions & 10 deletions doc/specs/drafts/#2046 - Command Palette.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ same as pressing the keybinding.
### Commands for each profile?
[#3879] Is a request for being able to launch a profile directly, via the
command pallete. Esentially, the user will type the name of a profile, and hit
command palette. Essentially, the user will type the name of a profile, and hit
enter to launch that profile. I quite like this idea, but with the current spec,
this won't work great. We'd need to manually have one entry in the command
palette for each profile, and every time the user adds a profile, they'd need to
Expand Down Expand Up @@ -173,11 +173,11 @@ ${profile.name}"`. When we then later expand the command, we'll see the
Trickily, we'll need to make sure to have a helper for replacing strings like
this that can be used for general purpose arg parsing. As you can see, the
`profile` property of the `newTab` command also needs the name of the profile.
Either the command validator will need to go through and update these strings
Either the command validation will need to go through and update these strings
manually, or we'll need another of enabling these `IActionArgs` classes to fill
those parameters in based on the profile being used. Perhaps the command
pre-expansion could just stash the json for the action, then expand it later?
This implementation detail is why this particualr feature is not slated for
This implementation detail is why this particular feature is not slated for
inclusion in an initial Command Palette implementation.
## UI/UX Design
Expand Down Expand Up @@ -206,7 +206,7 @@ the first entry in the list.
The user can navigate the list of entries with the arrow keys. Hitting enter
will close the palette and execute the action that's highlighted. Hitting escape
will dismiss the pallete, returning control to the terminal. When the palette is
will dismiss the palette, returning control to the terminal. When the palette is
closed for any reason (executing a command, dismissing with either escape or the
`toggleCommandPalette` keybinding), we'll clear out any search text from the
palette, so the user can start fresh again.
Expand Down Expand Up @@ -254,7 +254,7 @@ name, to show how their input correlates to the results on screen.
As the entire command palette will be a native XAML element, it'll automatically
be hooked up to the UIA tree, allowing for screen readers to naturally find it.
* When the palette is opened, it will automatically recieve focus.
* When the palette is opened, it will automatically receive focus.
* The terminal panes will not be able to be interacted with while the palette
is open, which will help keep the UIA tree simple while the palette is open.
Expand Down Expand Up @@ -287,7 +287,7 @@ to the commands list, so that everyone wouldn't need to define them manually.
We'll be adding a few extra XAML elements to our tree which will certainly
increase our runtime memory footprint while the palette is open.
We'll aditionally be introducing a few extra json values to parse, so that could
We'll additionally be introducing a few extra json values to parse, so that could
increase our load times (though this will likely be negligible).
## Potential Issues
Expand All @@ -298,7 +298,7 @@ However, when the command palette is opened, focus will move out of the terminal
control into the command palette, which leads to some hard to debug crashes.
Additionally, we'll need to ensure that the "fuzzy search" algorithm proposed
above will work for non-english languages, where a single charater might be
above will work for non-english languages, where a single character might be
multiple `char`s long. As we'll be using a standard XAML text box for input, we
won't need to worry about handling the input ourselves.
Expand Down Expand Up @@ -330,7 +330,7 @@ We'll check at parse time if the `name` property is a string or an object. If
it's a string, we'll treat that string as the literal text. Otherwise, if it's
an object, we'll attempt to use the `key` property of that object to look up a
string from our `ResourceDictionary`. This way, we'll be able to ship localized
strings for all the built-in commands, while aslo allowing the user to easily
strings for all the built-in commands, while also allowing the user to easily
add their own commands.
During the spec review process, we considered other options for localization as
Expand Down Expand Up @@ -360,7 +360,7 @@ The `{ "key": "resourceName" }` solution proposed here was also touched on in
relatively well, so long as you're sitting at a shell prompt. If you were in
an application like `vim`, this might be handy for executing a sequence of
vim-specific keybindings. Otherwise, you're just going to end up writing a
commadline to the buffer of vim. It would be weird, but not unexpected.
commandline to the buffer of vim. It would be weird, but not unexpected.
* Additionally mentioned in [#2046] was the potential for profile-scoped
commands. While that's a great idea, I believe it's out of scope for this
spec.
Expand All @@ -372,7 +372,7 @@ The `{ "key": "resourceName" }` solution proposed here was also touched on in
the `ListViewItem` for the command. We'd need some way to correlate a
command's action to a keybinding's action. This could be done in a follow-up
task.
* We might want to alter the fuzzy-search algorithim, to give higher precedence
* We might want to alter the fuzzy-search algorithm, to give higher precedence
in the results list to commands with more consecutive matching characters.
Alternatively we could give more weight to commands where the search matched
the initial character of words in the command.
Expand Down

1 comment on commit 76e1184

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New misspellings found, please review:

  • ertical
  • plit
  • thoguh
To accept these changes, run the following commands
remove_obsolete_words=$(mktemp)
echo '#!/usr/bin/perl -ni
my $re=join "|", qw('"
aaaaa
aaaaaa
aaaaaaaaaaaaaaaaaaa
ABCDEFGHIJKLMNOPQRSTQ
ABCDEFGHIJPQRST
ABCDEFGHIJPQRSTQ
APPLOGIC
BBBB
BBBBBBBBBBBBBBBBBBBBBBBBBB
CCCC
DDDD
EEEE
ffff
ggggg
gggggg
ggggggg
hackathon
LLLLLLLL
QQQQ
RRRRRRR
Spc
unicodechar
usr
xxxx
"');
next if /^($re)(?:$| .*)/;
print;' > $remove_obsolete_words
chmod +x $remove_obsolete_words
for file in .github/actions/spell-check/whitelist/alphabet.txt .github/actions/spell-check/whitelist/web.txt .github/actions/spell-check/whitelist/whitelist.txt; do $remove_obsolete_words $file; done
rm $remove_obsolete_words
(
echo "
applogic
ertical
Hackathon
plit
thoguh
"
) | sort -u -f | perl -ne 'next unless /./; print' > new_whitelist.txt && mv new_whitelist.txt '.github/actions/spell-check/whitelist/76e11849fbfa2cfdd549cc595eb853e1459db06e.txt'
✏️ Contributor please read this
  • If the items listed above are names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • If they're APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • If they're just things you're using, please add them to an appropriate file in .github/actions/spell-check/whitelist/.
  • If you need to use a specific token in one place and it shouldn't generally be used, you can
    add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Please sign in to comment.