-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#8420 removed `SwitchToTab()` as a responsibility of `TabBase` and replaces `_mruTabActions` with `_mruTabs` (conceptually). This PR fixes the build break by... - replacing `TerminalPage`'s reference to the SettingsTab's SwitchToTab command, with a reference to the tab itself - using that reference to maintain existing tab switching behavior ## References #1564 - Settings UI #8420 - Command Palette + SwitchToTab refactoring ## PR Checklist * [X] Closes #8538 ## Validation Steps Performed ✅ Open SUI --> switch to a different tab --> try opening SUI again --> switches to existing SUI ✅ Open SUI --> switch to a different tab --> reorder tabs --> try opening SUI again --> switches to existing SUI
- Loading branch information
1 parent
69693f6
commit d676103
Showing
3 changed files
with
6 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters