Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defterm launches into quake window #10358

Closed
cinnamon-msft opened this issue Jun 7, 2021 · 3 comments · Fixed by #10823
Closed

Defterm launches into quake window #10358

cinnamon-msft opened this issue Jun 7, 2021 · 3 comments · Fixed by #10823
Assignees
@leonMSFT
Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.11

Comments

@cinnamon-msft
Copy link
Contributor

Windows Terminal version (or Windows build number)

1.9.1445.0

Other Software

No response

Steps to reproduce

  • Launch Windows Terminal Preview and ensure Terminal Preview is set as your default terminal
  • Open a quake window
  • Dismiss quake window with `Win+``
  • Close initial terminal window
  • Launch a ps1 file from file explorer

Since the quake window is the only open Terminal window, defterm launches into that instead of creating a new terminal instance.

Expected Behavior

A new terminal instance is created.

Actual Behavior

The quake window is opened and attempts to run the selected file.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 7, 2021
@cinnamon-msft cinnamon-msft added Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 7, 2021
@DHowett DHowett added this to the Terminal v1.10 milestone Jun 8, 2021
@zadjii-msft zadjii-msft self-assigned this Jul 12, 2021
@miniksa
Copy link
Member

miniksa commented Jul 12, 2021

I think #9475 might technically fix this as I believe the quake one won't allow other tabs to join it normally if dispatched through remoting...

@zadjii-msft zadjii-msft removed their assignment Jul 12, 2021
@leonMSFT leonMSFT self-assigned this Jul 28, 2021
@leonMSFT leonMSFT mentioned this issue Jul 29, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 29, 2021
@ghost ghost closed this as completed in #10823 Aug 5, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 5, 2021
ghost pushed a commit that referenced this issue Aug 5, 2021
@leonMSFT
[DefApp] Move from Monarch multi instance servers to Peasant single i…
76793b1 
…nstance servers (#10823)

- Monarch no longer sets itself up as a `CTerminalHandoff` multi instance server by default
- In fact, `CTerminalHandoff` will only ever be a single instance server 
- When COM needs a `CTerminalHandoff`, it launches `wt.exe -embedding`, which gets picked up by the Monarch and then gets handed off to itself/peasant depending on user settings.
- Peasant now recognizes the `-embedding` commandline and will start a `CTerminalHandoff` single instance listener, and receives the connection into a new tab.

Closes #10358
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 5, 2021
DHowett pushed a commit that referenced this issue Aug 25, 2021
@leonMSFT @DHowett
[DefApp] Move from Monarch multi instance servers to Peasant single i…
d44bb4e 
…nstance servers (#10823)

- Monarch no longer sets itself up as a `CTerminalHandoff` multi instance server by default
- In fact, `CTerminalHandoff` will only ever be a single instance server
- When COM needs a `CTerminalHandoff`, it launches `wt.exe -embedding`, which gets picked up by the Monarch and then gets handed off to itself/peasant depending on user settings.
- Peasant now recognizes the `-embedding` commandline and will start a `CTerminalHandoff` single instance listener, and receives the connection into a new tab.

Closes #10358
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10823, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10823, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonMSFT leonMSFT

Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.11
5 participants
@DHowett @miniksa @zadjii-msft @cinnamon-msft @leonMSFT