Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WinUI 2.6 (prerelease) #10508

Closed
DHowett opened this issue Jun 24, 2021 · 6 comments · Fixed by #10996 or #11240
Closed

Update to WinUI 2.6 (prerelease) #10508

DHowett opened this issue Jun 24, 2021 · 6 comments · Fixed by #10996 or #11240
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@DHowett
Copy link
Member

DHowett commented Jun 24, 2021 •
edited by zadjii-msft
Loading

As title.

migrie note:
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 24, 2021
@DHowett DHowett mentioned this issue Jun 24, 2021
Closed
@WSLUser

This comment has been minimized.

Sign in to view
@DHowett

This comment has been minimized.

Sign in to view
@WSLUser

This comment has been minimized.

Sign in to view
@DHowett

This comment has been minimized.

Sign in to view
@zadjii-msft zadjii-msft added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 6, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 6, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jul 6, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 6, 2021
This was referenced Aug 17, 2021
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 20, 2021
@ghost ghost closed this as completed in #10996 Aug 20, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 20, 2021
ghost pushed a commit that referenced this issue Aug 20, 2021
@DHowett
Upgrade to Microsoft.UI.Xaml 2.6.2 (or equivalent) (#10996)
cfdf03c 
This commit moves us from MUX 2.5 to MUX 2.6. I have temporarily
disabled the new control styles in `TerminalApp\App.xaml` by setting
`ControlsResourcesVersion` to `Version1`. There is no significant expected
visual impact.

Closes #10508
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 20, 2021
@zadjii-msft
Copy link
Member

😭

@zadjii-msft zadjii-msft reopened this Aug 26, 2021
@zadjii-msft zadjii-msft mentioned this issue Aug 26, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Sep 15, 2021
Merged
4 tasks
@ghost ghost added In-PR This issue has a related PR and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Sep 15, 2021
@ghost ghost closed this as completed in #11240 Sep 20, 2021
ghost pushed a commit that referenced this issue Sep 20, 2021
@zadjii-msft
Update to MUX 2.7 (#11240)
cfe14e8 
* this is the same thing as #10996, but with the fix that caused us to #11031  
* This includes microsoft/microsoft-ui-xaml#3769, so we had to make some adjustments to how we handle tab colors. It works the same as before.
* Should enable #11231 to be started
* [x] Closes #10508
* [x] Closes #7133
* [x] Closes #8948
* [ ] I need to finish letting my 19H1 VM boot to make sure unpackaged still works
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11240, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

@DavidZidar DavidZidar mentioned this issue Oct 23, 2021
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
3 participants
@DHowett @zadjii-msft @WSLUser