Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vertical scrollbar thumb does not expand to full size #13361

Closed
heaths opened this issue Jun 22, 2022 · 8 comments
Closed

The vertical scrollbar thumb does not expand to full size #13361

heaths opened this issue Jun 22, 2022 · 8 comments
Assignees
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@heaths
Copy link
Member

heaths commented Jun 22, 2022

Windows Terminal version

1.13.11432.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

  1. Write enough text to display a vertical scrollbar e.g. tree /f %windir%
  2. Hover mouse over scrollbar or even the thumb specifically

Expected Behavior

Thumb expands to a larger size as it does in Notepad (new Windows 11 version).

Actual Behavior

Thumb stays tiny as shown in screen grab below:

Terminal Scrollbar Issue

@heaths heaths added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 22, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2022
@zadjii-msft
Copy link
Member

zadjii-msft commented Jun 23, 2022

Huh.

gh-13361

any chance you have animations disabled in the OS? I honestly have no idea what could possibly cause this 😕

Maybe #12608?

@vefatica
Copy link

I have

image

and

Microsoft Windows 10 Pro for Workstations
10.0.19044.1766 (2009, 21H2)
WindowsTerminalPreview 1.14.2205.25001

I do not see the animation shown in @zadjii-msft's clip. Ditto in 1.13.2205.23001. The slider acts as if it's wider; i.e., I can grab it with the mouse a few pixels on either side. I just don't see the wider version.

@heaths
Copy link
Member Author

heaths commented Jun 23, 2022

Maybe #12608?

Animations are enabled. It could be related to that issue, though. I should've also mentioned I'm running 4K resolution. Assuming new notepad is using WinUI (I'm pretty sure it is), you can see the scrollbar works as I'd expect with modern UI.

To note: this also repros in Terminal Preview version 1.14.1452.0.

@zadjii-msft
Copy link
Member

If I had to guess, this regressed in #12608, but I have no idea why. We're just copy-pasting the scrollbar XAML in its entirety.

Do the scrollbars in the Settings UI work as expected? That might help narrow this down.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Jul 5, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 5, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jul 5, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 5, 2022
@vefatica
Copy link

vefatica commented Jul 5, 2022

Here, they're old-fashioned looking.

image

Microsoft Windows 10 Pro for Workstations
10.0.19044.1766 (2009, 21H2)

@heaths
Copy link
Member Author

heaths commented Jul 5, 2022

Do the scrollbars in the Settings UI work as expected? That might help narrow this down.

@zadjii-msft no, they exhibit the same always-narrow behavior as shown in my screenvid.

@zadjii-msft
Copy link
Member

Sticking Leonard on this since he's got a live repro. Presumably this is sure to our manual re-template of the scrollbar control, but I wouldn't begin to know what we broke.

@lhecker
Copy link
Member

lhecker commented Aug 24, 2022

I used to have this issue and it doesn't occur in the internal 1.16.2352.0 preview build anymore. Closing, because it'll be (hopefully - if I'm right) fixed in the upcoming 1.16 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants