-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Scrollbar 16dips again #12608
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I suppose.
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400 (cherry picked from commit da2cf8c)
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to 12dips. This is harder for folks to hit with the mouse, and isn't consistent with the rest of the scrollbars on the platform (as much as they can be). To work around this, we have to entirely copy the template for the ScrollBar into our XAML file. We're then also re-defining ScrollBarSize here to 16, so that the new template will pick up on the new value. This is kinda a pain, and we have to be careful to be sure to ingest an updated version of the template any time we update MUX. The latest Controlsv2 version of the template can be found at: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218 We're also planning on making this adjustable in the future (GH#9218), where we might need this anyways. ##### after, before: ![image](https://user-images.githubusercontent.com/18356694/156254464-1a9080f6-51ce-4619-b002-2a3c607cdf5f.png) ##### after overlayed on top of before ![image](https://user-images.githubusercontent.com/18356694/156254546-fccc3cee-12a3-4e1a-8fd7-7470f1ec93ad.png) ##### comparison ![image](https://user-images.githubusercontent.com/18356694/156257934-ec4ac840-c8ca-4fca-a848-08a32b1c55c3.png) * reported originally in #12395 * upstream: microsoft/microsoft-ui-xaml#6684 * closes an element of #12400
🎉 Handy links: |
BODGY: Controlsv2 changed the size of the scrollbars from 16dips to
12dips. This is harder for folks to hit with the mouse, and isn't
consistent with the rest of the scrollbars on the platform (as much
as they can be).
To work around this, we have to entirely copy the template for the
ScrollBar into our XAML file. We're then also re-defining
ScrollBarSize here to 16, so that the new template will pick up on
the new value.
This is kinda a pain, and we have to be careful to be sure to ingest
an updated version of the template any time we update MUX. The
latest Controlsv2 version of the template can be found at:
https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ScrollBar_themeresources.xaml#L218
We're also planning on making this adjustable in the future
(GH#9218), where we might need this anyways.
after, before:
after overlayed on top of before
comparison