Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty "folder" entry in "newTabMenu" causes WT to be unable to start #14557

Closed
PankajBhojwani opened this issue Dec 14, 2022 · 2 comments · Fixed by #14629
Closed

Empty "folder" entry in "newTabMenu" causes WT to be unable to start #14557

PankajBhojwani opened this issue Dec 14, 2022 · 2 comments · Fixed by #14629
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.17

Comments

@PankajBhojwani
Copy link
Contributor

PankajBhojwani commented Dec 14, 2022 •
edited
Loading

Windows Terminal version

1.17.3482.0

Windows build number

No response

Other Software

No response

Steps to reproduce

  1. In settings.json, update the "newtabMenu" setting to look like this:
    [
        {
            "type": "remainingProfiles"
        },
        {
            "type": "folder"
        }
    ],
  1. Launch Terminal

Expected Behavior

Either nothing happens, or Terminal gives me a warning

Actual Behavior

I get an empty window and a system error dialog that says "Windows Terminal.exe has stopped working"
@PankajBhojwani PankajBhojwani added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 14, 2022
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Dec 15, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Dec 15, 2022
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 15, 2022
@zadjii-msft
Copy link
Member

Stack is in



0:000> k
 # Child-SP          RetAddr               Call Site
00 00000087`896fe1c0 00007ffc`97013795     Microsoft_Terminal_Settings_Model!winrt::impl::consume_Windows_Foundation_Collections_IVector<winrt::Windows::Foundation::Collections::IVector<winrt::Microsoft::Terminal::Settings::Model::NewTabMenuEntry>,winrt::Microsoft::Terminal::Settings::Model::NewTabMenuEntry>::Size+0x20 [C:\a\_work\1\s\src\cascadia\TerminalSettingsModel\Generated Files\winrt\Windows.Foundation.Collections.h @ 201] 
01 (Inline Function) --------`--------     Microsoft_Terminal_Settings_Model!winrt::impl::get_end_iterator+0x9 [C:\a\_work\1\s\src\cascadia\TerminalSettingsModel\Generated Files\winrt\base.h @ 8591] 
02 (Inline Function) --------`--------     Microsoft_Terminal_Settings_Model!winrt::impl::consume_Windows_Foundation_Collections_IIterable<winrt::Windows::Foundation::Collections::IVector<winrt::Microsoft::Terminal::Settings::Model::NewTabMenuEntry>,winrt::Microsoft::Terminal::Settings::Model::NewTabMenuEntry>::end+0x9 [C:\a\_work\1\s\src\cascadia\TerminalSettingsModel\Generated Files\winrt\Windows.Foundation.Collections.h @ 727] 
03 00000087`896fe200 00007ffc`970136a0     Microsoft_Terminal_Settings_Model!winrt::Microsoft::Terminal::Settings::Model::implementation::FolderEntry::Entries+0x9d [C:\a\_work\1\s\src\cascadia\TerminalSettingsModel\FolderEntry.cpp @ 67] 
04 00000087`896fe2d0 00007ffc`a5de056c     Microsoft_Terminal_Settings_Model!winrt::impl::produce<winrt::Microsoft::Terminal::Settings::Model::implementation::FolderEntry,winrt::Microsoft::Terminal::Settings::Model::IFolderEntry>::Entries+0x24 [C:\a\_work\1\s\src\cascadia\TerminalSettingsModel\Generated Files\winrt\Microsoft.Terminal.Settings.Model.h @ 6015] 
05 00000087`896fe300 00007ffc`a5e03bfa     TerminalApp!winrt::impl::consume_Microsoft_Terminal_Settings_Model_ICommand<winrt::Microsoft::Terminal::Settings::Model::ICommand>::NestedCommands+0x38 [C:\a\_work\1\s\src\cascadia\TerminalApp\Generated Files\winrt\Microsoft.Terminal.Settings.Model.h @ 1069] 
06 00000087`896fe350 00007ffc`a5da9dd4     TerminalApp!winrt::TerminalApp::implementation::TerminalPage::_CreateNewTabFlyoutItems+0x863ae [C:\a\_work\1\s\src\cascadia\TerminalApp\TerminalPage.cpp @ 962] 
07 00000087`896fe5b0 00007ffc`a5e7c41b     TerminalApp!winrt::TerminalApp::implementation::TerminalPage::_CreateNewTabFlyout+0xf4 [C:\a\_work\1\s\src\cascadia\TerminalApp\TerminalPage.cpp @ 831] 
08 00000087`896feb00 00007ffc`a5e01de7     TerminalApp!winrt::TerminalApp::implementation::TerminalPage::_RefreshUIForSettingsReload+0x4f7 [C:\a\_work\1\s\src\cascadia\TerminalApp\TerminalPage.cpp @ 2908] 
09 00000087`896fed20 00007ffc`a5ddeed3     TerminalApp!winrt::TerminalApp::implementation::TerminalPage::SetSettings+0x8d96b [C:\a\_work\1\s\src\cascadia\TerminalApp\TerminalPage.cpp @ 144] 
0a 00000087`896feda0 00007ffc`a5dde7dd     TerminalApp!winrt::TerminalApp::implementation::AppLogic::ReloadSettings+0x123 [C:\a\_work\1\s\src\cascadia\TerminalApp\AppLogic.cpp @ 1077] 
0b 00000087`896fedf0 00007ffc`a5dde8ae     TerminalApp!`winrt::TerminalApp::implementation::AppLogic::AppLogic'::`2'::<lambda_1>::operator()+0x8d [C:\a\_work\1\s\src\cascadia\TerminalApp\AppLogic.cpp @ 198] 
0c (Inline Function) --------`--------     T

@zadjii-msft zadjii-msft self-assigned this Jan 4, 2023
@zadjii-msft zadjii-msft mentioned this issue Jan 4, 2023
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 4, 2023
@ghost ghost closed this as completed in #14629 Jan 19, 2023
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 19, 2023
ghost pushed a commit that referenced this issue Jan 19, 2023
@zadjii-msft
Fix a crash on startup with a folder entry without entries (#14629)
90485e4 
`_Entries` was getting default constructed to `nullptr`. We should be careful about that. 

Adds a test too, and fixes a regression in the local tests introduced in #13763.

Closes #14557
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14629, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Fix a crash on startup with a folder entry without entries microsoft/terminal
2 participants
@zadjii-msft @PankajBhojwani