Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active tab rounded corner graphics misaligned/incorrect in the tab row when Windows Display Scale set to 150% (recommended default settings on 14" FHD laptops) #14905

Closed
mullnerz opened this issue Feb 24, 2023 · 2 comments · Fixed by #15078
Closed

Active tab rounded corner graphics misaligned/incorrect in the tab row when Windows Display Scale set to 150% (recommended default settings on 14" FHD laptops) #14905

mullnerz opened this issue Feb 24, 2023 · 2 comments · Fixed by #15078
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@mullnerz
Copy link

Windows Terminal version

1.16.10262.0

Windows build number

10.0.22621.1265

Other Software

No response

Steps to reproduce

Set Windows display scale to 150% and open a new Windows Terminal window/tab.

Expected Behavior

Rounded corners for the active tab in the tab row should be displayed correctly.

Actual Behavior

Rounded corners displayed incorrectly:
Screenshot 2023-02-24 195700-zoom
Screenshot 2023-02-24 195317
@mullnerz mullnerz added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 24, 2023
@zadjii-msft
Copy link
Member

You know, this was reported before in #13725 (comment) but we never promoted it to a full issue. We should figure this out!

I bet this is due to the wacky way we're setting resources on the TabViewItems, though. Might need a fix in TabView itself. No way to know without deeper investigation.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) Area-Theming Anything related to the theming of elements of the window and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 1, 2023
@zadjii-msft zadjii-msft added this to the Backlog milestone Mar 1, 2023
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Mar 1, 2023
@zadjii-msft zadjii-msft mentioned this issue Mar 29, 2023
Closed
@zadjii-msft zadjii-msft linked a pull request Apr 4, 2023 that will close this issue
Upgrade to MUX 2.8 #15078
Merged
1 task
@zadjii-msft
Copy link
Member

Looks like this was fixed in #15708, in MUX 2.8. Neat!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Theming Anything related to the theming of elements of the window Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Upgrade to MUX 2.8 microsoft/terminal
2 participants
@mullnerz @zadjii-msft