-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to MUX 2.8 #15078
Upgrade to MUX 2.8 #15078
Conversation
this is a copy of the TabView style as of today's main, https://github.com/microsoft/microsoft-ui-xaml/blob/93e23c225c3f3a45878d8300426c6a45dc38c8aa/dev/TabView/TabView.xaml I'm gonna change this to see if we can fix this
… hovering doesn't work, but it's BETTER
This comment has been minimized.
This comment has been minimized.
Make sure you clean up the PR body! |
@DHowett Should we block while we wait on the WebView2 thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for a little.
@@ -8,7 +8,8 @@ | |||
<package id="Microsoft.VCRTForwarders.140" version="1.0.4" targetFramework="native" /> | |||
<package id="Microsoft.Internal.Windows.Terminal.ThemeHelpers" version="0.6.220404001" targetFramework="native" /> | |||
<package id="Microsoft.VisualStudio.Setup.Configuration.Native" version="2.3.2262" targetFramework="native" developmentDependency="true" /> | |||
<package id="Microsoft.UI.Xaml" version="2.7.3" targetFramework="native" /> | |||
<package id="Microsoft.UI.Xaml" version="2.8.2" targetFramework="native" /> | |||
<package id="Microsoft.Web.WebView2" version="1.0.1661.34" targetFramework="native" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO Dustin: look at the content of this package and see if we can suppress the DLL being copied in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at, fixed.
…15178) TL;DR: we stopped getting `TabView.TabItemsChanged`. This meant that the tab view would change its apparent order, but we wouldn't change the backing tab order. I'm fixing this by grabbing the index of the tab that starts the drag, and the index of the tab view item at the end of the drag, and using that to reorder our backing list. Closes #15121 Upstream microsoft/microsoft-ui-xaml#8388 Regressed in #15078 - I'm pretty confident about this, since I've got a 1.18.931 build of the Terminal with tear-out, but not MUX 2.8.
Set the padding to the default TabViewHeaderPadding (8,0,0,0), but with -1 on the bottom. This prevents a small 1px gap that can appear on 150% scale displays between the tab item and the content. The 1 on top helps keep the tab the correct relative height within the tab row. Regressed in #15078 See also MSFT:40692364
Updates the Terminal to Microsoft.UI.Xaml v2.8.
.props
checklist