Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align "Run this profile as Administrator" Settings Description with Microsoft Style Guidelines #16946

Closed
hellocharli opened this issue Mar 27, 2024 · 1 comment · Fixed by #16955
Closed

Align "Run this profile as Administrator" Settings Description with Microsoft Style Guidelines #16946

hellocharli opened this issue Mar 27, 2024 · 1 comment · Fixed by #16955
Labels
Area-Localization Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@hellocharli
Copy link
Contributor

Apologies if this isn't the right tag for this issue.

The setting description for the "Run this profile as Administrator" contains the contraction it'll, which is specifically discouraged in the official Microsoft Style Guide.

Avoid ambiguous or awkward contractions, such as there’d, it’ll, and they’d.

The string in question is on line 982 of main/src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
@hellocharli hellocharli added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Mar 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 27, 2024
@zadjii-msft
Copy link
Member

Yep, this should get fixed. Thanks for catching this!

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Area-Localization and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 27, 2024
@zadjii-msft zadjii-msft added this to the Backlog milestone Mar 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 27, 2024
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs labels Mar 27, 2024
@hellocharli hellocharli mentioned this issue Mar 27, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
@hellocharli
Replace 'it'll' with 'it will' to adhere to Microsoft Style Guidelines (
4458a6d 
#16955)

## Summary of the Pull Request

## References and Relevant Issues
Fixes "Align 'Run this profile as Administrator' Settings Description
with Microsoft Style Guidelines" #16946
## Detailed Description of the Pull Request / Additional comments
Expanded the contraction "it'll" to "it will" on line 993 of
`src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw`
## Validation Steps Performed
N/A

## PR Checklist
- [X] Closes #16946
- [ ] Tests added/passed
   - No tests were added
- [ ] Documentation updated
   - No documentation was updated
- [ ] Schema updated (if necessary)
   - No schema was updated
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Localization Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Replace 'it'll' with 'it will' to adhere to Microsoft Style Guidelines hellocharli/terminal
2 participants
@zadjii-msft @hellocharli