Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.22 We broke hot reload entirely #17364

Closed
zadjii-msft opened this issue Jun 4, 2024 · 3 comments
Closed

1.22 We broke hot reload entirely #17364

zadjii-msft opened this issue Jun 4, 2024 · 3 comments
Assignees
@zadjii-msft
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-Blocking We won't ship a release like this! No-siree.

Comments

@zadjii-msft
Copy link
Member

selfhost-1.22-bugbash-2024-06-04

culprits:
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Jun 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 4, 2024
@zadjii-msft
Copy link
Member Author

(i'll try to find the culprit in the morning)

@zadjii-msft zadjii-msft self-assigned this Jun 4, 2024
@zadjii-msft
Copy link
Member Author

Uh, CascadiaSettings::LoadAll isn't called at all in hot reload. Neither is the lambda inside AppLogic::_RegisterSettingsChange. Uh, what? the call to AppLogic::_RegisterSettingsChange got entirely removed?? I'm betting it was a bad merge. I'm the murderer aren't I?

@zadjii-msft
Copy link
Member Author

Okay, found the regression in #16916. You may return to your regularly scheduled anything else.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
@zadjii-msft zadjii-msft mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zadjii-msft