Fix some search highlights scenarios #17352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added a commit
that referenced
this pull request
Jun 4, 2024
lhecker
reviewed
Jun 4, 2024
Comment on lines
+164
to
+168
| // Stop ongoing close animation if any | ||
| if (CloseAnimation().GetCurrentState() == Media::Animation::ClockState::Active) | ||
| { | ||
| CloseAnimation().Stop(); | ||
| } |
There was a problem hiding this comment.
I'm not sure I understand how us previously ignoring the animation state would result in
Fast closing and re-opening SearchBox would leave search highlights in an inconsistent state.
If you know why, could you explain how that happens?
There was a problem hiding this comment.
When searchbox is in focus, if you press ESC and then quickly do a "find next/prev match" action, it will trigger this issue. The trick is to start a search when SB is closing. It's easier if you bind Find match action to a single key, eg. F3
There was a problem hiding this comment.
Not to forget, highlights should be active (i.e. one or more search results available) when you're closing SB.
lhecker
approved these changes
Jun 7, 2024
carlos-zamora
approved these changes
Jun 13, 2024
DHowett
approved these changes
Jun 13, 2024
DHowett
pushed a commit
that referenced
this pull request
Jun 20, 2024
Fixes: - Snapping the current match to the current selection doesn't work. - Fast closing and re-opening SearchBox would leave search highlights in an inconsistent state. The highlights would be active even when SB is not on the screen, and results are not updated as more text is added to the buffer. - Search highlights scroll marks are not cleared when the search box is closed. (cherry picked from commit 7c1e229) Service-Card-Id: 92736967 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: