Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles.schema.json: NewTerminalArgs section is outdated #17469

Closed
htcfreek opened this issue Jun 24, 2024 · 0 comments · Fixed by #17696
Closed

profiles.schema.json: NewTerminalArgs section is outdated #17469

htcfreek opened this issue Jun 24, 2024 · 0 comments · Fixed by #17696
Labels
Area-Schema Things that have to do with the json schema. In-PR This issue has a related PR Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@htcfreek
Copy link

htcfreek commented Jun 24, 2024 •
edited
Loading

The NewTerminalArgs section in the file doc/cascadia/profiles.schema.json is outdated.

Some of the existing arguments that can be saved to json are not listed.
@htcfreek htcfreek added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Jun 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 24, 2024
@PankajBhojwani PankajBhojwani added Product-Terminal The new Windows Terminal. Area-Schema Things that have to do with the json schema. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 26, 2024
@PankajBhojwani PankajBhojwani added this to the Terminal v1.22 milestone Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 26, 2024
@PankajBhojwani PankajBhojwani added Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) labels Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 26, 2024
@carlos-zamora carlos-zamora mentioned this issue Aug 9, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. In-PR This issue has a related PR Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

schema: add reloadEnvironmentVariables to newTerminalArgs microsoft/terminal
2 participants
@PankajBhojwani @htcfreek