schema: add reloadEnvironmentVariables to newTerminalArgs #17696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Docs
DHowett
approved these changes
Aug 9, 2024
DHowett
changed the title
lhecker
reviewed
Aug 9, 2024
carlos-zamora
commented
Aug 12, 2024
DHowett
approved these changes
Aug 13, 2024
DHowett
requested changes
Aug 13, 2024
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
Co-authored-by: Dustin L. Howett <[email protected]>
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
pushed a commit
that referenced
this pull request
Aug 20, 2024
(cherry picked from commit 1511d2c) Service-Card-Id: 93522518 Service-Version: 1.20
DHowett
pushed a commit
that referenced
this pull request
Aug 20, 2024
(cherry picked from commit 1511d2c) Service-Card-Id: 93522519 Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the schema to include
reloadEnvironmentVariablesfor New Terminal Args.Other properties that aren't included:
__content: we're explicitly not including this in the schema since it's only used internally. In fact, we even throw an error if it is defined (sample code)!sessionId: there isn't really a legit use for this one, so we'll leave it undocumented and as an implementation detail.Closes #17469