Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better icons for Visual Studio Developer Command Prompt/Powershell profiles #17627

Closed
stamminator opened this issue Jul 29, 2024 · 1 comment · Fixed by #17706
Closed

Better icons for Visual Studio Developer Command Prompt/Powershell profiles #17627

stamminator opened this issue Jul 29, 2024 · 1 comment · Fixed by #17706
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@stamminator
Copy link

Description of the new feature/enhancement

Custom icons for the Developer PowerShell for VS 2022 and Developer Command Prompt for VS 2022 profiles would be a nice touch.

5tXWrREqj0

Proposed technical implementation details (optional)

Include images in the app's ProfileIcons/ directory and automatically use them for said profiles. I threw these together in GIMP. If they are satisfactory, feel free to use them.

cmd_vs

powershell5_vs

@stamminator stamminator added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 29, 2024
@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 31, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Jul 31, 2024
@DHowett
Copy link
Member

DHowett commented Aug 12, 2024

Thanks for the inspiration, and the suggestion! We got in touch with the Visual Studio design team and they made a set of icons for us that look pretty similar to your concept, except with some of the original shell icons punched out to form a keep-out zone.

You can see them over in #17706!

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 13, 2024
DHowett added a commit that referenced this issue Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer
PowerShell from our friends over on Visual Studio!

This pull request includes them in the package, and fixes up the VS
dynamic profiles to reset any icons that matched the old paths.

This may be a minor breaking change for user settings, but we're making
the assumption that if they didn't change their VS profile icons from
the defaults, they probably want to follow us to the new defaults.

To prevent anything like this from happening again, we're going to stop
serializing icons for stub profiles.

I've also included a VS version of the PowerShell "black" icon which is
currently unused, but can be used in the future for PS7+-based VS Dev
Shell.

Closes #17627

(cherry picked from commit 06c07ab)
Service-Card-Id: 93531228
Service-Version: 1.20
DHowett added a commit that referenced this issue Aug 20, 2024
We got some new icons for Developer Command Prompt and Developer
PowerShell from our friends over on Visual Studio!

This pull request includes them in the package, and fixes up the VS
dynamic profiles to reset any icons that matched the old paths.

This may be a minor breaking change for user settings, but we're making
the assumption that if they didn't change their VS profile icons from
the defaults, they probably want to follow us to the new defaults.

To prevent anything like this from happening again, we're going to stop
serializing icons for stub profiles.

I've also included a VS version of the PowerShell "black" icon which is
currently unused, but can be used in the future for PS7+-based VS Dev
Shell.

Closes #17627

(cherry picked from commit 06c07ab)
Service-Card-Id: 93531229
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants