Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering the search to display 0 actions does not clear the preview #17773

Closed
Tracked by #15845
zadjii-msft opened this issue Aug 22, 2024 · 1 comment · Fixed by #17777
Closed
Tracked by #15845

Filtering the search to display 0 actions does not clear the preview #17773

zadjii-msft opened this issue Aug 22, 2024 · 1 comment · Fixed by #17777
Labels
In-PR This issue has a related PR Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 22, 2024 •
edited
Loading

sshhh bot
@zadjii-msft zadjii-msft mentioned this issue Aug 22, 2024
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 22, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service

This comment was marked as off-topic.

Sign in to view
@zadjii-msft zadjii-msft reopened this Aug 22, 2024
zadjii-msft added a commit that referenced this issue Aug 22, 2024
@zadjii-msft
Dismiss the snippet preview when there is no suggestions
6aff623 
Pretty obvious in retrospect. If there's no results, then we need to preview
_nothing_ to make sure that we clear out any old previews.

Closes #17773
@zadjii-msft zadjii-msft mentioned this issue Aug 22, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR This issue has a related PR Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dismiss the snippet preview when there is no suggestions microsoft/terminal
1 participant
@zadjii-msft