Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "X" used to close a tab is too wide. #18060

Closed
destenson opened this issue Oct 15, 2024 · 4 comments
Closed

The "X" used to close a tab is too wide. #18060

destenson opened this issue Oct 15, 2024 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@destenson
Copy link

destenson commented Oct 15, 2024

Windows Terminal version

1.20.11781.0

Windows build number

No response

Other Software

No response

Steps to reproduce

  • Open many tabs and/or make the window "small" (<HD).
  • Quickly click other tabs to switch between them repeatedly.
  • Accidentally close the tab you're trying to select.

Expected Behavior

I expect the close button to be harder to accidentally click.

Alternatively, I expect the application to give me the option to cancel accidentally closing the tab I'm trying to select. Clicking close on a tab that is not in the foreground is almost always unintentional.

Actual Behavior

The "X" region used to close a tab is way too wide, especially when there are many tabs open. The "X" button is 3 times wider than the X icon, and can take 20% or more of the tab's region.

As a result, up to 20% of the time, when selecting a tab, I accidentally close the tab.

@destenson destenson added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 15, 2024
@j4james
Copy link
Collaborator

j4james commented Oct 15, 2024

Clicking close on a tab that is not in the foreground is almost always unintentional.

In that case, you may find the Theme Settings helpful - there's an option you can set so the close button only appears on the active tab, i.e. the one in the foreground (see Show close button).

Alternatively, I expect the application to give me the option to cancel accidentally closing the tab I'm trying to select.

I believe that feature is being tracked in issue #5301.

@destenson
Copy link
Author

destenson commented Oct 16, 2024

@j4james, thank you for the info. The themes setting looks like it might work. It's quite inconvenient that can't be changed from the gui, though.

And wrt #5301, that appears to be for showing a confirmation dialog when you close the whole window with multiple tabs open, not for closing a background tab.

@carlos-zamora
Copy link
Member

Thanks for filing! #5301 is more about a confirmation dialog when you close the tab, not the window. So in your case, it would prevent you from actually closing the tab immediately.

We're going to mark this as a /dup of #5301. Though it's not allowing you to modify the width of the X button, we feel that the combination of the theme setting mentioned above and #5301 should resolve the need for your ask.

Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants