Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeTab should present a confirmation dialog #5301

Open
carlos-zamora opened this issue Apr 9, 2020 · 5 comments
Open

closeTab should present a confirmation dialog #5301

carlos-zamora opened this issue Apr 9, 2020 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

closeTab should present a confirmation dialog if multiple panes are open. This would prevent users from accidentally closing all panes in a tab by accident.

@carlos-zamora carlos-zamora added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Apr 9, 2020
@carlos-zamora carlos-zamora added this to the Terminal v1.x milestone Apr 9, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 9, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 9, 2020
@ghost ghost added the In-PR This issue has a related PR label May 13, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jul 25, 2020
@ghost ghost added the In-PR This issue has a related PR label Jul 26, 2020
@eugenesvk
Copy link

I'd suggest to have this user-configurable so that you could have both a close-without-confirmation command and a close-with-confirmation one and bind them to separate keybinds if you like (e.g. with the latter command bound to combo less fat-finger prone)

@htcfreek
Copy link

I had the same request in the linked issue. One suggestion I'd like to mention here is that you should ask the user what to do instead of simply warning the user.

Example

Tab with split-pane: powershell | cmd
Question:

What should be closed?
Closing the last tab closes the whole window.

[*this pane*] [tab] [cancel]

@Vampire
Copy link

Vampire commented Jul 5, 2023

Please also make it possible to show a warning on simple tab closing, not only with multiple panes.
It happened multiple times to me that I accidentally closed a tab and sometimes there were even processes running inside.
I'd prefer to always be warned before closing a tab.

@zadjii-msft
Copy link
Member

Yep, I'm pretty sure that's tracked as a part of #6549 (comment).

@tovine
Copy link

tovine commented Aug 5, 2023

Same here, I just misclicked and lost one of my tabs with an active SSH connection and ongoing work.
At least ask for confirmation if a process (like SSH) is running, closing an "idle" terminal is OK but one that is in use is sad 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
8 participants