Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Customize confirmation prompt before exit. #2976

Open
1 task
gdevacc12 opened this issue Sep 29, 2019 · 20 comments
Open
1 task

Feature Request: Customize confirmation prompt before exit. #2976

gdevacc12 opened this issue Sep 29, 2019 · 20 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@gdevacc12
Copy link

gdevacc12 commented Sep 29, 2019

Feature request: A confirmation prompt before terminal app exit.
For example, if there are multiple tabs open, upon initiation of exit a prompt to confirm or cancel exit.

Particularly with the case when multiple tabs open, prompting the user to think before closing multiple tabs may prevent a accidental loss of work/processing in tabs that are not in the foreground.

Perhaps make the prompt configurable in settings with the options:

  • disabled (no prompt before exit)
  • multiple (prompt if multiple tabs open)
  • always (prompt always before exit - for a check before closing even a single open tab)
@gdevacc12 gdevacc12 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 29, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 29, 2019
@DHowett-MSFT DHowett-MSFT added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Area-User Interface Issues pertaining to the user interface of the Console or Terminal and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 30, 2019
@DHowett-MSFT
Copy link
Contributor

We'll use this to track the work to connect #1589 to the close button.

@DHowett-MSFT DHowett-MSFT added the Help Wanted We encourage anyone to jump in on these. label Sep 30, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Sep 30, 2019
@cinnamon-msft cinnamon-msft changed the title Feature Request: Confirmation prompt before exit. Feature Request: Customize confirmation prompt before exit. Jan 23, 2020
@dpopiashvili
Copy link

Would be nice if it will be configurable per profile. I don't need confirmation when closing cmd tab, but might need one if I'm using SSH

@stela2502
Copy link

I am using the terminal app together with the WLS and R.

If I am in a similar situation using Ubuntu the terminal asks if I close a tab that contains a running process. If I have a resting tab with just the command prompt waiting for some input I can close the tab without any questions, but if I have an R or ssh session running I get the confirmation dialogue.

I think this would actually be the best way to make everybody kind of happy - right?

@jroskey
Copy link

jroskey commented Jun 20, 2020

New user here, and am loving the new Windows Terminal. In regards to the 'Prompt on close' Can there please be a 'Remember my answer' option to prevent it from coming up every time if we don't want it to? Or can this be done in the Setting .json file?

Thanks in advance!

@DHowett
Copy link
Member

DHowett commented Jun 20, 2020

You can set confirmCloseOnExit to false. Check out the documentation! 😄

@jroskey
Copy link

jroskey commented Jun 20, 2020

You can set confirmCloseOnExit to false. Check out the documentation! 😄

Thank you!!!!

@ouweiya
Copy link

ouweiya commented Jul 15, 2020

This is now "confirmCloseAllTabs"

@jroskey
Copy link

jroskey commented Jul 15, 2020 via email

@fgimian
Copy link

fgimian commented Jul 19, 2020

Is there a way to always confirm when closing (even with a single tab)? I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted. I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.

Huge thanks
Fotis

@Chips1234
Copy link
Contributor

Is there a way to always confirm when closing (even with a single tab)? I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted. I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.

Huge thanks

Fotis

@fgimian sorry for the late reply! I'm working on implementing it right now

@fgimian
Copy link

fgimian commented Jul 28, 2020

Is there a way to always confirm when closing (even with a single tab)? I just hit Alt+F4 by mistake on a Terminal window which was half way through a PowerShell script and wasn't prompted. I'm not sure if there's a way to detect a running action, but ideally it should never exit without prompt while a script or similar is running in the window imho.
Huge thanks
Fotis

@fgimian sorry for the late reply! I'm working on implementing it right now

Thank you so much! 😄

@Chips1234
Copy link
Contributor

Chips1234 commented Jul 28, 2020 via email

@ghost ghost added the In-PR This issue has a related PR label Jul 30, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@mailinglists35
Copy link

ooops, I've closed a tab by mistake. not big work lost, but I was just an ENTER keypress away from starting a long script.
what is the status of this?

@zadjii-msft
Copy link
Member

what is the status of this?

I've got about 50% of the spec written over in: #6549 (comment). Just needs time to flush that out to a proper doc, and implement it.

@stiltet
Copy link

stiltet commented May 10, 2022

The confirmCloseAllTabs is not enough. It needs to confirm also if only one tab but multiple windows in that tab is present. I just work and time now because it closes without confirmation... 😒

@zadjii-msft
Copy link
Member

@stiltet Yep, that's all a part of #6549 (comment)

@coopstah13
Copy link

How about hiding the close X except on the active tab? Typically the ones I accidentally close are not the tab I'm currently active in (because I'm trying to switch tabs). Perhaps if you hover long enough on the tab the X appears, but it seems like it would prevent a lot of accidents if you have to activate the tab first before you can close it.

@zadjii-msft
Copy link
Member

@coopstah13 That particular element we're tracking in #3335, namely, #3335 (comment)

@AkikoOrenji
Copy link

is still still waiting deployment ? I just lost a bunch of work by hitting the x on a tab by mistake (no prompt if i meant it) :(

@zadjii-msft
Copy link
Member

Yep. There still hasn't been any progress on formalizing #6549 (comment) nor any work done to actually implement that yet.

@zadjii-msft zadjii-msft removed the In-PR This issue has a related PR label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.