Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid closing window when close last tab. #6276

Open
aixfox opened this issue May 30, 2020 · 12 comments
Open

Avoid closing window when close last tab. #6276

aixfox opened this issue May 30, 2020 · 12 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@aixfox
Copy link

aixfox commented May 30, 2020

Description of the new feature/enhancement

Avoid closing window when close last tab.

Proposed technical implementation details (optional)

Keep terminal window when 0 tabs exist, not be concern about the last tab how to be closed.

Features/News/Terminal list, are good contents in the empty window view.

Like Firefox/Chrome/ConEmu which is popular tab manager does.

@aixfox aixfox added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 30, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 30, 2020
@electronic-dk
Copy link

I believe this issue covers exactly this

@aixfox
Copy link
Author

aixfox commented May 30, 2020

I believe this issue covers exactly this

Same proposal in a sense.

But views of #4579 #2976 #627 are tabs, not window, they are different concepts. Behavior confirm or prevent of tabs are meaningless.

@zadjii-msft
Copy link
Member

I actually don't hate this. But we'd probably need to get something like #3586 in first, so that we could just re-use that UI as the "pick a profile" UI.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jun 1, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 1, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jun 1, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 1, 2020
@WSLUser
Copy link
Contributor

WSLUser commented Jun 2, 2020

I expect the window to close when there is only one tab open and I close it (the last tab as I see it). I have no idea what would still show in the window if there are 0 tabs, perhaps a black empty space that supports no input other than opening a new tab via drop-down menu? This doesn't seem all that useful to me and actually a deterrent. I wouldn't close Terminal without good reason, such as a reboot or adding a WSL distro since we're still waiting for support on hot-loading distros that are added to the profile list (and appearing in the drop-down menu.) If this "feature" is added, I recommend it be disabled by default and be explicitly turned on in settings.json under "defaults".

@aixfox
Copy link
Author

aixfox commented Jun 3, 2020

I expect the window to close when there is only one tab open and I close it (the last tab as I see it). I have no idea what would still show in the window if there are 0 tabs, perhaps a black empty space that supports no input other than opening a new tab via drop-down menu? This doesn't seem all that useful to me and actually a deterrent. I wouldn't close Terminal without good reason, such as a reboot or adding a WSL distro since we're still waiting for support on hot-loading distros that are added to the profile list (and appearing in the drop-down menu.) If this "feature" is added, I recommend it be disabled by default and be explicitly turned on in settings.json under "defaults".

Here is a user story:
Close a tab -> Open other tabs.
If the window is not opened always and the tab closed is the latest, user should do:
Close a tab -> Find "Windows Terminal" application in OS -> Open default tab (default behavoir) -> Open other tabs -> Close unnecessary default tab.

It is confused.

Most browsers/editors/ternimal managers support this requirement, and their blank pages are helpful for what would be rendered in Windows Ternimal with 0 tabs.

@WSLUser
Copy link
Contributor

WSLUser commented Jun 3, 2020

Browsers are different. I haven't seen a terminal have this feature. Please state precedence (i.e. in VTE/xterm/Iterm2/etc. this works ).

@aixfox
Copy link
Author

aixfox commented Jun 3, 2020

Browsers are different. I haven't seen a terminal have this feature. Please state precedence (i.e. in VTE/xterm/Iterm2/etc. this works ).

Managers of terminal, not terminal itself.

Here are some products: ConEmu/XShell/Terminus/MobaXterm.

@zadjii-msft
Copy link
Member

Browsers are different. I haven't seen a terminal have this feature. Please state precedence (i.e. in VTE/xterm/Iterm2/etc. this works ).

I don't think there needs to be existing precedence for Terminal UI features like this. For something like VT sequence support, sure. However, I like this idea as a differentiating one.

Obviously this would be behind a setting, because most people probably just want the window to close when the last tab is closed, but giving the users the option for this functionality isn't a bad idea.

@WSLUser
Copy link
Contributor

WSLUser commented Jun 3, 2020

I actually do remember ConEmu having the feature. It was annoying for me and was glad when I could switch to Terminal. I'm glad this wouldn't be the default and instead an explicit setting.

@aixfox
Copy link
Author

aixfox commented Jun 6, 2020

ok, just a setting feature request.

@DHowett
Copy link
Member

DHowett commented Jun 6, 2020

This is definitely a duplicate of 4579 (if you read the comments), but this one has more info so I’m closing the other one.

@ndac-todoroki
Copy link

I use Konsole when I use Kubuntu, and Konsole has this feature (actually I'm using Yakuake, the quake-typed version of Konsole).
Avoid closing window is great especially on quake mode, where the application should always be alive (so you can show/hide the terminal window by a global hotkey).
Currently there is no quake mode on Windows Terminal, but there are some go-arounds using AutoHotkey, which I am using. The AH script doesn't work when Windows Terminal is closed.

Also, I usually just close the tab when I need to re-login on WSL2. Maybe this isn't the best way to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants