Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of selectionBackground & addition of selectionForeground #4971

Closed
linuxluzer opened this issue Mar 18, 2020 · 2 comments
Closed

Rework of selectionBackground & addition of selectionForeground #4971

linuxluzer opened this issue Mar 18, 2020 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@linuxluzer
Copy link

selectionBackground-selectionForeground

While making the new WT look and feel like Powershell, the selectionBackground property seems affected by an acrylic effect that reduces contrast for accessibility and causes an ugly sensation whit some color schemes. It should be a true/false option that triggers the cmd/powershell mode (full opacity). In that case, a selectionForeground could be added too, in order to address the parity features with conhost.exe.

A technical implementation in profiles.json could be something like this (don´t have enough C++ knowledge for real code):

"profiles":
    {
        "list":
        [
            {
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "selectionOpacity": true,
                "selectionBackground": "#fedba9",
                "selectionForeground": "#ffffff",
                "hidden": false
             }
        ]
    }
@linuxluzer linuxluzer added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 18, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 18, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks for the request! This is, at its heart, a /dupe of #3580 and #3561. 😄

@ghost
Copy link

ghost commented Mar 18, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 18, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 18, 2020
DHowett added a commit that referenced this issue Aug 19, 2024
…a overlay (#17725)

With the merge of #17638, selections are now accumulated early in the
rendering process. This allows Atlas, which currently makes decisions
about cell foreground/background at the time of text rendering,
awareness of the selection ranges *before* text rendering begins.

As a result, we can now paint the selection into the background and
foreground bitmaps. We no longer need to overlay a rectangle, or series
of rectangles, on top of the rendering surface and alpha blend the
selection color onto the final image.

As a reminder, "alpha selection" was always a stopgap because we didn't
have durable per-cell foreground and background customization in the
original DxEngine.

Selection foregrounds are not customizable, and will be chosen using the
same color distancing algorithm as the cursor. We can make them
customizable "easily" (once we figure out the schema for it) for #3580.

`ATLAS_DEBUG_SHOW_DIRTY` was using the `Selection` shading type to draw
colored regions. I didn't want to break that, so I elected to rename the
`Selection` shading type to `FilledRect` and keep its value. It helps
that the shader didn't have any special treatment for
`SHADING_TYPE_SELECTION`.

This fixes the entire category of issues created by selection being an
80%-opacity white rectangle. However, given that it changes the imputed
colors of the text it will reveal `SGR 8` concealed/hidden characters.

Refs #17355
Refs #14859
Refs #11181
Refs #8716
Refs #4971
Closes #3561
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants