-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About and Close all dialogs do not correctly show all UI elements #5195
Comments
Just to confirm: this doesn't happen in v0.10 from the store? |
Correct, this does not happen in v0.10 from the store. |
Tested v0.10.781.0, this does not occur there. |
Because we cannot set RequestedTheme at the application level, we occasionally run into issues where parts of our UI end up themed incorrectly. Dialogs, for example, live under a different Xaml root element than the rest of our application. This makes our popup menus and buttons "disappear" when the user wants Terminal to be in a different theme than the rest of the system. This hack---and it _is_ a hack--walks up a dialog's ancestry and forces the theme on each element up to the root. We're relying a bit on Xaml's implementation details here, but it does have the desired effect. It's not enough to set the theme on the dialog alone. Fixes #3654. Fixes #5195.
I'm gonna mark this as a /dupe of #3654, since it's the same root cause and solution. |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Because we cannot set RequestedTheme at the application level, we occasionally run into issues where parts of our UI end up themed incorrectly. Dialogs, for example, live under a different Xaml root element than the rest of our application. This makes our popup menus and buttons "disappear" when the user wants Terminal to be in a different theme than the rest of the system. This hack---and it _is_ a hack--walks up a dialog's ancestry and forces the theme on each element up to the root. We're relying a bit on Xaml's implementation details here, but it does have the desired effect. It's not enough to set the theme on the dialog alone. Fixes #3654. Fixes #5195.
🎉This issue was addressed in #5224, which has now been successfully released as Handy links: |
Environment
Steps to reproduce
a. On the About dialog, hover over a hyperlink and observe it disappear
b. On the Close all dialog, observe that the Cancel button is not visible (but is active because it Cancels when clicking the area where the button is located.
Expected behavior
Actual behavior
The text was updated successfully, but these errors were encountered: