Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About and Close all dialogs do not correctly show all UI elements #5195

Closed
encladeus opened this issue Mar 31, 2020 · 6 comments · Fixed by #5224
Closed

About and Close all dialogs do not correctly show all UI elements #5195

encladeus opened this issue Mar 31, 2020 · 6 comments · Fixed by #5224
Assignees
@DHowett-MSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@encladeus
Copy link

Environment

Windows build number: [10.0.18363.720]
Windows Terminal version: latest unreleased build from master

Any other software? No

Steps to reproduce

  1. Windows default app mode: light
  2. Windows terminal requestedTheme: dark
  3. Open About or Close all dialog
  4. Observe not all graphical elements are visible
    a. On the About dialog, hover over a hyperlink and observe it disappear
    b. On the Close all dialog, observe that the Cancel button is not visible (but is active because it Cancels when clicking the area where the button is located.

Expected behavior

  1. About dialog: Can see the hyperlink when hovering over it with mouse cursor
  2. Close all dialog: Can see the Cancel button.

Actual behavior

  1. About dialog: Cannot see the hyperlink when hovering over it with mouse cursor

help

  1. Close all dialog: Cannot see the Cancel button.

close-all
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 31, 2020
@DHowett-MSFT
Copy link
Contributor

Just to confirm: this doesn't happen in v0.10 from the store?

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 31, 2020
@encladeus
Copy link
Author

Correct, this does not happen in v0.10 from the store.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 31, 2020
@carlos-zamora
Copy link
Member

Tested v0.10.781.0, this does not occur there.
But it does occur on ca6b54e

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Apr 1, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 1, 2020
@cinnamon-msft cinnamon-msft added this to the Terminal v1.0 milestone Apr 2, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 2, 2020
@DHowett
Force all our dialogs into the application theme
a48bff8 
Because we cannot set RequestedTheme at the application level, we
occasionally run into issues where parts of our UI end up themed
incorrectly.  Dialogs, for example, live under a different Xaml root
element than the rest of our application. This makes our popup menus and
buttons "disappear" when the user wants Terminal to be in a different
theme than the rest of the system.  This hack---and it _is_ a
hack--walks up a dialog's ancestry and forces the theme on each element
up to the root. We're relying a bit on Xaml's implementation details
here, but it does have the desired effect.

It's not enough to set the theme on the dialog alone.

Fixes #3654.
Fixes #5195.
@DHowett-MSFT DHowett-MSFT mentioned this issue Apr 2, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 2, 2020
@DHowett-MSFT DHowett-MSFT added Priority-1 A description (P1) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 3, 2020
@DHowett-MSFT
Copy link
Contributor

I'm gonna mark this as a /dupe of #3654, since it's the same root cause and solution.

@ghost
Copy link

ghost commented Apr 3, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 3, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Apr 3, 2020
ghost pushed a commit that referenced this issue Apr 3, 2020
@DHowett
Force all our dialogs into the application theme, forcibly (#5224)
9513d54 
Because we cannot set RequestedTheme at the application level, we
occasionally run into issues where parts of our UI end up themed
incorrectly.  Dialogs, for example, live under a different Xaml root
element than the rest of our application. This makes our popup menus and
buttons "disappear" when the user wants Terminal to be in a different
theme than the rest of the system.  This hack---and it _is_ a
hack--walks up a dialog's ancestry and forces the theme on each element
up to the root. We're relying a bit on Xaml's implementation details
here, but it does have the desired effect.

It's not enough to set the theme on the dialog alone.

Fixes #3654.
Fixes #5195.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 3, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5224, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

@DHowett DHowett mentioned this issue Dec 1, 2020
Closed
@aquinn39 aquinn39 mentioned this issue Jul 23, 2022
Open
2 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Force all our dialogs into the application theme, forcibly microsoft/terminal
5 participants
@encladeus @carlos-zamora @DHowett-MSFT @zadjii-msft @cinnamon-msft