-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach CommandPalette to natively support tabs and command lines #8415
Labels
Area-CmdPal
Command Palette issues and features
Area-CodeHealth
Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Product-Terminal
The new Windows Terminal.
Milestone
Comments
Don-Vito
added
the
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
label
Nov 27, 2020
ghost
added
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Needs-Tag-Fix
Doesn't match tag requirements
labels
Nov 27, 2020
@DHowett - can you please assign this one to me? 😊 |
Happy to 😄 thanks |
This was referenced Nov 27, 2020
zadjii-msft
added
Area-CodeHealth
Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Product-Terminal
The new Windows Terminal.
and removed
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
labels
Nov 29, 2020
ghost
pushed a commit
that referenced
this issue
Dec 10, 2020
…#8420) First step towards #8415: * Introduce `PaletteItem` and derive from it to provide native support for tabs and command lines (`ActionPaletteItem` / `TabPaletteItem`, `CommandLinePaltteItem`) * Remove business logic behind PaletteItem from palette (aka dispatch commands and preview tabs externally)
This was referenced Dec 25, 2020
ghost
pushed a commit
that referenced
this issue
Jan 4, 2021
ghost
pushed a commit
that referenced
this issue
Jan 19, 2021
A part of the #8415. Includes: * Moving `TabSwitcherMode` related decisions into `CommandPalette` (simplifying the logic of `TerminalPage::SelectNextTab`) * Fix a bug where the index of first tab switch is incorrect (since bindings are not updated) * Removing redundant `CommandPalette` updates * Preparations for tabs binding
mpela81
pushed a commit
to mpela81/terminal
that referenced
this issue
Jan 28, 2021
…microsoft#8420) First step towards microsoft#8415: * Introduce `PaletteItem` and derive from it to provide native support for tabs and command lines (`ActionPaletteItem` / `TabPaletteItem`, `CommandLinePaltteItem`) * Remove business logic behind PaletteItem from palette (aka dispatch commands and preview tabs externally)
mpela81
pushed a commit
to mpela81/terminal
that referenced
this issue
Jan 28, 2021
A part of the microsoft#8415. Very technical commit to simplify the terminal page code towards additional steps of simplifying tab management. No business logic should change. A firs step in splitting microsoft#8427
mpela81
pushed a commit
to mpela81/terminal
that referenced
this issue
Jan 28, 2021
A part of the microsoft#8415. Includes: * Moving `TabSwitcherMode` related decisions into `CommandPalette` (simplifying the logic of `TerminalPage::SelectNextTab`) * Fix a bug where the index of first tab switch is incorrect (since bindings are not updated) * Removing redundant `CommandPalette` updates * Preparations for tabs binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-CmdPal
Command Palette issues and features
Area-CodeHealth
Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Product-Terminal
The new Windows Terminal.
Description of the new feature/enhancement
Currently command palette has a single set of UIEelements that present different sets of Commands. This approach has a lot of gaps:
Proposed technical implementation details (optional)
My plan to achieve it gradually is following:
PaletteItem
and derive from it to provide a native support for tabs and command lines (ActionPaletteItem
/TabPaletteItem
,CommandLinePaltteItem
)The text was updated successfully, but these errors were encountered: