Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-underline hyperlink on hover-out, even if not focused #8925

Closed
PhMajerus opened this issue Jan 28, 2021 · 6 comments · Fixed by #9039
Closed

De-underline hyperlink on hover-out, even if not focused #8925

PhMajerus opened this issue Jan 28, 2021 · 6 comments · Fixed by #9039
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.7

Comments

@PhMajerus
Copy link

Testing WT Preview 1.6.10272.0.

Ok, now that we got the underline hyperlink on hover, even when not focused (#8475, #8615)... can we have them always de-underline on mouseout as well? You know, for consistency? 😉

Right now, the underline gets removed only when another hyperlink gets underlined, not when the mouse moves away from it.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 28, 2021
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2021
@zadjii-msft zadjii-msft added good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements labels Jan 29, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Jan 29, 2021
@zadjii-msft
Copy link
Member

YUP we should do that, good catch.

@Don-Vito
Copy link
Contributor

Don-Vito commented Jan 30, 2021 •
edited
Loading

@zadjii-msft - I am wondering why we chose to implement #8475 rather than #6459. Won't it make the behavior more consistent and prevent issues like this one?

And it is also a one liner 😄

@Don-Vito Don-Vito mentioned this issue Jan 30, 2021
Merged
6 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 4, 2021
@DHowett
Copy link
Member

DHowett commented Feb 4, 2021

@Don-Vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined when the whole window is out of focus?

FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. 😄

@Don-Vito
Copy link
Contributor

Don-Vito commented Feb 4, 2021

@Don-Vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined when the whole window is out of focus?

FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. 😄

@DHowett - what you mention regarding the entire window losing focus is another aspect that requires a fix, but it is not related directly to this report. The problem here is due to a gap in the implementation of mouse hover over unfocused pane. And the fix here will be different from the fix that will be required for window losing focus.

My suggestion for FFM is replacing the code that introduced this gap. I was not aware though that FFM is so controversial 😊

@Don-Vito
Copy link
Contributor

Don-Vito commented Feb 4, 2021

I am handing this separately from FFM.

@Don-Vito Don-Vito mentioned this issue Feb 4, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 4, 2021
DHowett pushed a commit that referenced this issue Feb 5, 2021
@Don-Vito
Fix hyperlink not de-underlined in unfocused pane (#9039)
40e3289 
Ensures that:
* All hyperlink related logic is running on unfocused pane
* All unrelated logic is not running on unfocused pane

Closes #8925
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 5, 2021
DHowett pushed a commit that referenced this issue Feb 5, 2021
@Don-Vito @DHowett
Fix hyperlink not de-underlined in unfocused pane (#9039)
b80f6de 
Ensures that:
* All hyperlink related logic is running on unfocused pane
* All unrelated logic is not running on unfocused pane

Closes #8925

(cherry picked from commit 40e3289)
@ghost
Copy link

ghost commented Feb 11, 2021

🎉This issue was addressed in #9039, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.:tada:

Handy links:

@PhMajerus PhMajerus mentioned this issue Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.7
Development

Successfully merging a pull request may close this issue.

Fix hyperlink not de-underlined in unfocused pane Don-Vito/terminal
4 participants
@DHowett @Don-Vito @zadjii-msft @PhMajerus