-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-underline hyperlink on hover-out, even if not focused #8925
Comments
YUP we should do that, good catch. |
@zadjii-msft - I am wondering why we chose to implement #8475 rather than #6459. Won't it make the behavior more consistent and prevent issues like this one? And it is also a one liner 😄 |
@Don-Vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined when the whole window is out of focus? FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. 😄 |
@DHowett - what you mention regarding the entire window losing focus is another aspect that requires a fix, but it is not related directly to this report. The problem here is due to a gap in the implementation of mouse hover over unfocused pane. And the fix here will be different from the fix that will be required for window losing focus. My suggestion for FFM is replacing the code that introduced this gap. I was not aware though that FFM is so controversial 😊 |
I am handing this separately from FFM. |
Ensures that: * All hyperlink related logic is running on unfocused pane * All unrelated logic is not running on unfocused pane Closes #8925
🎉This issue was addressed in #9039, which has now been successfully released as Handy links: |
Testing WT Preview 1.6.10272.0.
Ok, now that we got the underline hyperlink on hover, even when not focused (#8475, #8615)... can we have them always de-underline on mouseout as well? You know, for consistency? 😉
Right now, the underline gets removed only when another hyperlink gets underlined, not when the mouse moves away from it.
The text was updated successfully, but these errors were encountered: