Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow keys no longer work in the Tab Switcher #9130

Closed
zadjii-msft opened this issue Feb 12, 2021 · 5 comments
Closed

Arrow keys no longer work in the Tab Switcher #9130

zadjii-msft opened this issue Feb 12, 2021 · 5 comments
Assignees
@Don-Vito
Labels
Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.7

Comments

@zadjii-msft
Copy link
Member

This is on Preview Version: 1.7.413.0, which is basically just main. Usually you can open that tab switcher and use the arrow keys to navigate the list, like the command palette. Now it seems that interaction no longer works?

Might have been broken in #9056? Unsure if that made the 1.7 selfhost though.

/cc @Don-Vito as an fyi
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-CmdPal Command Palette issues and features labels Feb 12, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Feb 12, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 12, 2021
@Don-Vito
Copy link
Contributor

@zadjii-msft - please assign to me. I will try to take a look during the weekend

@zadjii-msft
Copy link
Member Author

@Don-Vito awesome, thanks ☺️

@Don-Vito
Copy link
Contributor

Like it is sure that change. When merging the handlers, I was not aware that arrows are in use in tab switcher (because you still need an anchor to be held) and added a short circuit.

@Don-Vito Don-Vito mentioned this issue Feb 12, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 12, 2021
@ghost ghost closed this as completed in 5ffb945 Feb 13, 2021
DHowett pushed a commit that referenced this issue Feb 23, 2021
@Don-Vito @DHowett
Re-enable navigation in ATS (#9140)
b544298 
## PR Checklist
* [x] Closes #9130
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit 5ffb945)
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9140, which has now been successfully released as Windows Terminal v1.6.10571.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9140, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Don-Vito Don-Vito

Labels
Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.7
Development

No branches or pull requests
2 participants
@Don-Vito @zadjii-msft