Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollToBottom command makes viewport jump between the top and the bottom of the output buffer #9353

Closed
et342 opened this issue Mar 3, 2021 · 4 comments
Closed

scrollToBottom command makes viewport jump between the top and the bottom of the output buffer #9353

et342 opened this issue Mar 3, 2021 · 4 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@et342
Copy link

et342 commented Mar 3, 2021 •
edited
Loading

Environment

Windows build number: [10.0.21292.1010]
Windows Terminal commit: [7b1a660e590012893407a64f4321f01ba74a6e9b]

Steps to reproduce

  • Ctrl+Shit+End is bound to scrollToBottom
  • Have some text in the output buffer exceeding the height of the terminal window
  • Scroll to the the middle of the buffer, not to the top or the bottom.
  • Start repeatedly pressing Ctrl+Shift+End

Expected behavior

  • Viewport jumps to the bottom of the buffer and stays there.

Actual behavior

  • Viewport first jumps to the top of the buffer and then jumps between the bottom and the top of the buffer on each keystroke.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2021
@zadjii-msft
Copy link
Member

WOAH yea that's wrong. Good catch, thanks!

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 3, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 3, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 3, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 3, 2021
@Don-Vito
Copy link
Contributor

Don-Vito commented Mar 5, 2021

On it

@Don-Vito Don-Vito mentioned this issue Mar 5, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 5, 2021
@ghost ghost closed this as completed in 1202f89 Mar 5, 2021
DHowett pushed a commit that referenced this issue Mar 15, 2021
@Don-Vito @DHowett
Fix overflow in scroll-to-bottom (#9389)
458a140 
## PR Checklist
* [x] Closes #9353
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit 1202f89)
DHowett pushed a commit that referenced this issue Mar 15, 2021
@Don-Vito @DHowett
Fix overflow in scroll-to-bottom (#9389)
7f1bdaf 
## PR Checklist
* [x] Closes #9353
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

(cherry picked from commit 1202f89)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9389, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9389, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
4 participants
@Don-Vito @zadjii-msft @et342 and others