Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask/warn on closing last tab of split pane #9876

Closed
htcfreek opened this issue Apr 17, 2021 · 6 comments
Closed

Ask/warn on closing last tab of split pane #9876

htcfreek opened this issue Apr 17, 2021 · 6 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@htcfreek
Copy link

htcfreek commented Apr 17, 2021 •
edited
Loading

Description of the new feature/enhancement

I have split-pane-mode with one tab per pane enabled. Closing one of the tabs (the last tab of a pane) closes the whole window.

Better would be to warn/ask the user.

Left pane Right pane
one tab (powershell) one tab (cmd)

Proposed technical implementation details (optional)

On closing the last tab of a split pane the user should be asked what to do:

  • Close pane.
  • Close window.
  • Cancel.
@htcfreek htcfreek added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 17, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2021
@Don-Vito
Copy link
Contributor

@htcfreek - I guess there is some naming confusion:

  • We have application Window
  • One or more tab are displayed on the top of this Window (like in a browser)
  • Each tab contains one or more panes
  • Each pane contains a terminal

Given this terminology, is you ask is about "Prompt upon closing the last pane of the tab"?

@htcfreek
Copy link
Author

htcfreek commented Apr 18, 2021 •
edited
Loading

@Don-Vito
I agree to you that I misunderstand the UX hierarchy (window > tabs > panes).
But then for me the window was closed with two panes open in the last tab.

wt-close-splitpane

  1. There should be a warning that both panes are destroyed on closing the tab/window.
  2. Maybe it's possible to make it more clear that there are more than one console open in this tab. (I have an idea and upload a mock up later.)
    image

@Don-Vito
Copy link
Contributor

Don-Vito commented Apr 18, 2021 •
edited
Loading

@htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if #5301 already addresses the same idea.

@htcfreek
Copy link
Author

htcfreek commented Apr 18, 2021 •
edited
Loading

@htcfreek - Thanks for the screen capture! What you ask makes a lot of sense! I was asking about the terminology just to check if we have such request already. Please see if #5301 already addresses the same idea.

@Don-Vito
Yes the issue addresses the same idea. I'll add a suggestion in the other issue.
Should I open a new issue for the suggestion of split-pane info and close my issue?

@Don-Vito
Copy link
Contributor

I believe that you can repurpose this issue for adding panes info to the Tab title. I remember of seeing similar idea in some discussion but I cannot find it right now.

@htcfreek htcfreek mentioned this issue Apr 18, 2021
Closed
@htcfreek
Copy link
Author

Closing as duplicate of #9883 and #5301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Don-Vito @htcfreek