-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary work to add Swap Panes functionality (GH Issues 1000, 4922) #10638
Commits on Jul 20, 2021
-
Preliminary work to add Swap Panes functionality (GH Issues 1000, 4922)
- Add boilerplate/infrastructure for argument parsing, hotkeys, event handling - Adds the "MovePane" function that finds the focused pane, and then tries to find a pane that is visually adjacent to according to direction. - First pass at the "SwapPanes" function that swaps the tree location of two panes - First "working" version of helpers _FindFocusAndNeighbor and _FindNeighborFromFocus that search the tree for the currently focused pane, and then climbs back up the tree to try to find a sibling pane that is adjacent to it. The actual `_IsAdjacent' function is just a stub. Once working these functions could be utilized to also solve GH issue 2398.
Configuration menu - View commit details
-
Copy full SHA for d364cfd - Browse repository at this point
Copy the full SHA d364cfdView commit details -
Add an actual visual-adjacency testing implementation
- FindFocusAndNeighbor and FindNeighborFromFocus now record a relative offset of their children. - _IsAdjacent now properly tests if two panes, given eachs' relative offsets are adjacent according to direction.
Configuration menu - View commit details
-
Copy full SHA for dc81ee0 - Browse repository at this point
Copy the full SHA dc81ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fda879 - Browse repository at this point
Copy the full SHA 0fda879View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbc4d4e - Browse repository at this point
Copy the full SHA fbc4d4eView commit details -
Dont overwrite borders after we swap panes, actually assign the row/c…
…olumn locations to the correct elements.
Configuration menu - View commit details
-
Copy full SHA for 5123c2d - Browse repository at this point
Copy the full SHA 5123c2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69bb7b4 - Browse repository at this point
Copy the full SHA 69bb7b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49e888e - Browse repository at this point
Copy the full SHA 49e888eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 983c58a - Browse repository at this point
Copy the full SHA 983c58aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4397d16 - Browse repository at this point
Copy the full SHA 4397d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53382d0 - Browse repository at this point
Copy the full SHA 53382d0View commit details
Commits on Jul 21, 2021
-
Code review: update out of date comment. Refactor recursion in swap p…
…anes to find parents. Add checks to make sure there are enough panes to actually find the previous one.
Configuration menu - View commit details
-
Copy full SHA for 10b86fb - Browse repository at this point
Copy the full SHA 10b86fbView commit details