Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary work to add Swap Panes functionality (GH Issues 1000, 4922) #10638

Merged
11 commits merged into from
Jul 22, 2021

Commits on Jul 20, 2021

  1. Preliminary work to add Swap Panes functionality (GH Issues 1000, 4922)

    - Add boilerplate/infrastructure for argument parsing, hotkeys, event handling
    - Adds the "MovePane" function that finds the focused pane, and then tries to find
      a pane that is visually adjacent to according to direction.
    - First pass at the "SwapPanes" function that swaps the tree location of two panes
    - First "working" version of helpers _FindFocusAndNeighbor and _FindNeighborFromFocus
      that search the tree for the currently focused pane, and then climbs back up the tree
      to try to find a sibling pane that is adjacent to it. The actual `_IsAdjacent' function
      is just a stub.
      Once working these functions could be utilized to also solve GH issue 2398.
    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d364cfd View commit details
    Browse the repository at this point in the history
  2. Add an actual visual-adjacency testing implementation

    - FindFocusAndNeighbor and FindNeighborFromFocus now record a relative offset of
      their children.
    - _IsAdjacent now properly tests if two panes, given eachs' relative offsets
      are adjacent according to direction.
    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    dc81ee0 View commit details
    Browse the repository at this point in the history
  3. Run code formatting tool

    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    0fda879 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fbc4d4e View commit details
    Browse the repository at this point in the history
  5. Dont overwrite borders after we swap panes, actually assign the row/c…

    …olumn locations to the correct elements.
    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5123c2d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    69bb7b4 View commit details
    Browse the repository at this point in the history
  7. Run code formatter again

    Rosefield committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    49e888e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    983c58a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4397d16 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    53382d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Code review: update out of date comment. Refactor recursion in swap p…

    …anes to find parents. Add checks to make sure there are enough panes to actually find the previous one.
    Rosefield committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    10b86fb View commit details
    Browse the repository at this point in the history